net/url_request/url_request_job_tracker.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job_tracker.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_job_tracker.cc

diff --git a/net/url_request/url_request_job_tracker.cc b/net/url_request/url_request_job_tracker.cc

index 49472d901968545c9e7797fd027a80c2da77ced2..632d0a38f47729549093abfc7631310ca3997536 100644

--- a/net/url_request/url_request_job_tracker.cc

+++ b/net/url_request/url_request_job_tracker.cc

@@ -17,7 +17,7 @@ URLRequestJobTracker::URLRequestJobTracker() {

}

URLRequestJobTracker::~URLRequestJobTracker() {

- DLOG_IF(WARNING, active_jobs_.size() != 0) <<

+ DLOG_IF(WARNING, !active_jobs_.empty()) <<

"Leaking " << active_jobs_.size() << " URLRequestJob object(s), this "

"could be because the URLRequest forgot to free it (bad), or if the "

"program was terminated while a request was active (normal).";