chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc

diff --git a/chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc b/chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc

index 13fa63ce931a45c494162edff990fd97d9cf0e82..00a42b1fcb2c50f53496c03471e91ad056e8ae94 100644

--- a/chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc

+++ b/chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc

@@ -52,7 +52,7 @@ TEST_F(EncodingMenuControllerTest, ListEncodingMenuItems) {

controller.GetEncodingMenuItems(&profile_en, &english_items);

// Make sure there are items in the lists.

- ASSERT_TRUE(english_items.size() > 0);

+ ASSERT_FALSE(english_items.empty());

// Make sure that autodetect is the first item on both menus

ASSERT_EQ(english_items[0].first, IDC_ENCODING_AUTO_DETECT);

}