chrome/browser/history/history_types.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_types.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_types.cc

diff --git a/chrome/browser/history/history_types.cc b/chrome/browser/history/history_types.cc

index 65b1935aff1578c9c089a007cfef28d0a8b2838d..9f56ff0e0377e728589316498c6c061ee91af4d6 100644

--- a/chrome/browser/history/history_types.cc

+++ b/chrome/browser/history/history_types.cc

@@ -174,7 +174,7 @@ const size_t* QueryResults::MatchesForURL(const GURL& url,

// All entries in the map should have at least one index, otherwise it

// shouldn't be in the map.

- DCHECK(found->second->size() > 0);

+ DCHECK(!found->second->empty());

if (num_matches)

*num_matches = found->second->size();

return &found->second->front();