chrome/browser/extensions/extension_updater_unittest.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_updater_unittest.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_updater_unittest.cc

diff --git a/chrome/browser/extensions/extension_updater_unittest.cc b/chrome/browser/extensions/extension_updater_unittest.cc

index 067bd869f2f06b744744f404dcd26019e622655f..5c04289fdfa6197e55ffcf386d4d596a60ab13cb 100644

--- a/chrome/browser/extensions/extension_updater_unittest.cc

+++ b/chrome/browser/extensions/extension_updater_unittest.cc

@@ -279,7 +279,7 @@ static void ExtractParameters(const std::string& params,

for (size_t i = 0; i < pairs.size(); i++) {

std::vector<std::string> key_val;

base::SplitString(pairs[i], '=', &key_val);

- if (key_val.size() > 0) {

+ if (!key_val.empty()) {

std::string key = key_val[0];

EXPECT_TRUE(result->find(key) == result->end());

(*result)[key] = (key_val.size() == 2) ? key_val[1] : "";