chrome/browser/autocomplete/autocomplete_match.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_match.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/autocomplete_match.cc

diff --git a/chrome/browser/autocomplete/autocomplete_match.cc b/chrome/browser/autocomplete/autocomplete_match.cc

index f05892eb4ebd8ff944a801956cfc936c0e6d7d8f..e19f156a417bcf77998f82d8c4547d698f56277f 100644

--- a/chrome/browser/autocomplete/autocomplete_match.cc

+++ b/chrome/browser/autocomplete/autocomplete_match.cc

@@ -166,7 +166,7 @@ void AutocompleteMatch::ValidateClassifications(

}

// The classifications should always cover the whole string.

- DCHECK(classifications.size() > 0) << "No classification for text";

+ DCHECK(!classifications.empty()) << "No classification for text";

DCHECK(classifications[0].offset == 0) << "Classification misses beginning";

if (classifications.size() == 1)

return;