Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4954)

Unified Diff: chrome/browser/download/download_util.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Up Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_util.cc
diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc
index 69dcce6c74af8b2d854cc7e9de1bba0f748c886c..280b688984ae3153a0545b69c4c8aef20ef15d31 100644
--- a/chrome/browser/download/download_util.cc
+++ b/chrome/browser/download/download_util.cc
@@ -113,7 +113,7 @@ bool IsShellIntegratedExtension(const string16& extension) {
// See <http://www.juniper.net/security/auto/vulnerabilities/vuln2612.html>.
// That vulnerability report is not exactly on point, but files become magical
// if their end in a CLSID. Here we block extensions that look like CLSIDs.
- if (extension_lower.size() > 0 && extension_lower.at(0) == L'{' &&
+ if (!extension_lower.empty() && extension_lower.at(0) == L'{' &&
Peter Kasting 2011/03/03 19:35:53 Nit: at() -> [] (this would be another good change
extension_lower.at(extension_lower.length() - 1) == L'}')
return true;

Powered by Google App Engine
This is Rietveld 408576698