chrome/browser/ui/window_snapshot/window_snapshot_mac.mm - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/window_snapshot/window_snapshot_mac.mm

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/webui/bug_report_ui.cc ('k') | chrome/browser/webdata/web_data_service.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/window_snapshot/window_snapshot.h"	5 #include "chrome/browser/ui/window_snapshot/window_snapshot.h"

6	6

7 #import <Cocoa/Cocoa.h>	7 #import <Cocoa/Cocoa.h>

8	8

9 #include "base/logging.h"	9 #include "base/logging.h"

10 #include "base/mac/scoped_cftyperef.h"	10 #include "base/mac/scoped_cftyperef.h"

(...skipping 17 matching lines...) Expand all Loading...
28	28

29 scoped_nsobject<NSBitmapImageRep> rep(	29 scoped_nsobject<NSBitmapImageRep> rep(

30 [[NSBitmapImageRep alloc] initWithCGImage:windowSnapshot]);	30 [[NSBitmapImageRep alloc] initWithCGImage:windowSnapshot]);

31 NSData* data = [rep representationUsingType:NSPNGFileType properties:nil];	31 NSData* data = [rep representationUsingType:NSPNGFileType properties:nil];

32 const unsigned char* buf = static_cast<const unsigned char*>([data bytes]);	32 const unsigned char* buf = static_cast<const unsigned char*>([data bytes]);

33 NSUInteger length = [data length];	33 NSUInteger length = [data length];

34 if (buf == NULL \|\| length == 0)	34 if (buf == NULL \|\| length == 0)

35 return gfx::Rect();	35 return gfx::Rect();

36	36

37 png_representation->assign(buf, buf + length);	37 png_representation->assign(buf, buf + length);

38 DCHECK(png_representation->size() > 0);	38 DCHECK(!png_representation->empty());

39	39

40 return gfx::Rect(static_cast<int>([rep pixelsWide]),	40 return gfx::Rect(static_cast<int>([rep pixelsWide]),

41 static_cast<int>([rep pixelsHigh]));	41 static_cast<int>([rep pixelsHigh]));

42 }	42 }

43	43

44 } // namespace browser	44 } // namespace browser

OLD	NEW