Disable view-source if the page source is not viewable as text....

Disable view-source if the page source is not viewable as text.
For example, a page of content type application/x-shockwave-flash
is not viewable.

BUG=9562

[yuzo, 2009-04-11 00:34:51]

Hi, Ben,

Can you review this?

Yuzo

[yuzo, 2009-04-14 16:55:30]

Ping?

[Ben Goodger (Google), 2009-04-14 18:13:15]

Sorry for my tardiness.

http://codereview.chromium.org/66061/diff/1003/4
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/66061/diff/1003/4#newcode2183
Line 2183: net::IsSupportedNonImageMimeType(
why not call IsViewSourceMimeType instead? that seems to be what you want

[yuzo, 2009-04-14 18:26:26]

Thank you for the review. Can you take another look?

http://codereview.chromium.org/66061/diff/1003/4
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/66061/diff/1003/4#newcode2183
Line 2183: net::IsSupportedNonImageMimeType(
On 2009/04/14 18:13:15, Ben Goodger wrote:
> why not call IsViewSourceMimeType instead? that seems to be what you want

You are right. Changed to call it.

[Ben Goodger (Google), 2009-04-14 18:27:38]

LGTM

[yuzo, 2009-04-14 18:55:45]

On 2009/04/14 18:27:38, Ben Goodger wrote:
> LGTM

Can you hold on a second? I found a bug in mime_util.cc.
I'll ask for review shortly.

[yuzo, 2009-04-14 19:15:56]

Sorry, I have been totally confused.

Can you take yet another look, and commit the change if appropriate?

I changed the code to call
  net::IsSupportedNonImageMimeType
again.

Rationale:
- net::IsViewSourceMimeType returns true for the mime types
  that itself (i.e., rather than its source) should be presented
  in view-source mode. Hence it returns false for text/html or
  text/plain, for example.
- net::IsSupportedNonImageMimeType returns true for the mime types
  whose source is text. Hence this fits the purpose of this change.

Yuzo

On 2009/04/14 18:55:45, yuzo wrote:
> On 2009/04/14 18:27:38, Ben Goodger wrote:
> > LGTM
> 
> Can you hold on a second? I found a bug in mime_util.cc.
> I'll ask for review shortly.