Issue 6606005: Simplify test for typeof x == 'Object' on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6606005: Simplify test for typeof x == 'Object' on all platforms. (Closed)

Created:
9 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Simplify test for typeof x == 'y' on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=7041

Patch Set 4 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -176 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2 3	1 chunk	+27 lines, -46 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3	2 chunks	+19 lines, -36 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2 3	2 chunks	+19 lines, -33 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	4 chunks	+13 lines, -22 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2 3	2 chunks	+15 lines, -28 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3	2 chunks	+9 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Arm full-codegen not done yet, not all changes made to ARM lithium.

9 years, 9 months ago (2011-03-02 17:31:53 UTC) #1

fschneider

LGTM. http://codereview.chromium.org/6606005/diff/12001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/6606005/diff/12001/src/arm/full-codegen-arm.cc#newcode4020 src/arm/full-codegen-arm.cc:4020: __ CompareInstanceType(r0, r1, FIRST_FUNCTION_CLASS_TYPE); Could you reuse the ...

9 years, 9 months ago (2011-03-03 12:05:02 UTC) #2

William Hesse

9 years, 9 months ago (2011-03-03 12:16:13 UTC) #3

http://codereview.chromium.org/6606005/diff/12001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6606005/diff/12001/src/arm/full-codegen-arm.cc...
src/arm/full-codegen-arm.cc:4020: __ CompareInstanceType(r0, r1,
FIRST_FUNCTION_CLASS_TYPE);
On 2011/03/03 12:05:02, fschneider wrote:
> Could you reuse the value of the instance type from r1 left by
CompareObjectType
> here?

It is being reused, and it is in r0.  R1 is just a scratch register, not the map
register.

Expand Messages | Collapse Messages

Issue 6606005: Simplify test for typeof x == 'Object' on all platforms. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages