Issue 660452: Assign to "sample.state" before reading it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660452: Assign to "sample.state" before reading it. (Closed)

Created:
10 years, 9 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Assign to "sample.state" before reading it. I noticed a funny thing: in StackTracer::Trace "sample.state" is checked, but it is only assigned after the check. I've put assignment before the check. Committed: http://code.google.com/p/v8/source/detail?r=4017

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -10 lines)			Patch
M	src/platform-freebsd.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/platform-linux.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/platform-macos.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/platform-win32.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages