Make OSX TestShell able to run workers, using a new test_worker.dylib which i...

Make OSX TestShell able to run workers, using a new test_worker.dylib which is basically a webkit+v8+helpers to simulate separate process with worker v8 threads. This is similar way we do on Win32.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13537

[Dmitry Titov, 2009-04-10 18:38:53]

Mark - could you please take a look at gyp/gypi files (new dylib and PIC code
generation).
Jian - Could you take a general look since you did the WIN32 impl.
Thanks!

[Mark Mentovai, 2009-04-10 18:45:46]

http://codereview.chromium.org/66043/diff/1/5
File build/common.gypi (right):

http://codereview.chromium.org/66043/diff/1/5#newcode200
Line 200: 'GCC_DYNAMIC_NO_PIC': 'NO',
You can just remove this line.  NO is the default.

http://codereview.chromium.org/66043/diff/1/3
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/66043/diff/1/3#newcode393
Line 393: # Need to do the same for Win and Linux. We build a separate
dylib/dll/so so the
80 cols for comments

http://codereview.chromium.org/66043/diff/1/3#newcode402
Line 402: 'EXPORTED_SYMBOLS_FILE':
'../../../chrome/test/worker/test_worker.exp',
Why would you put test_worker.exp in the chrome directory if test_worker is a
test_shell target?

http://codereview.chromium.org/66043/diff/1/3#newcode415
Line 415: '../../../chrome/test/worker/test_webworker.cc',
Similar question for these.  I think that either these files should move into
test_shell or the target should move into chrome.  I think that having project
files reach across the tree like this is freaky.

[Dmitry Titov, 2009-04-10 19:32:12]

http://codereview.chromium.org/66043/diff/1/5
File build/common.gypi (right):

http://codereview.chromium.org/66043/diff/1/5#newcode200
Line 200: 'GCC_DYNAMIC_NO_PIC': 'NO',
On 2009/04/10 18:45:46, Mark Mentovai wrote:
> You can just remove this line.  NO is the default.

Done.

http://codereview.chromium.org/66043/diff/1/3
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/66043/diff/1/3#newcode393
Line 393: # Need to do the same for Win and Linux. We build a separate
dylib/dll/so so the
On 2009/04/10 18:45:46, Mark Mentovai wrote:
> 80 cols for comments

Done.

http://codereview.chromium.org/66043/diff/1/3#newcode402
Line 402: 'EXPORTED_SYMBOLS_FILE':
'../../../chrome/test/worker/test_worker.exp',
On 2009/04/10 18:45:46, Mark Mentovai wrote:
> Why would you put test_worker.exp in the chrome directory if test_worker is a
> test_shell target?

Agreed. Sent email to ask for the best location, will do as a separate CL.

http://codereview.chromium.org/66043/diff/1/3#newcode415
Line 415: '../../../chrome/test/worker/test_webworker.cc',
On 2009/04/10 18:45:46, Mark Mentovai wrote:
> Similar question for these.  I think that either these files should move into
> test_shell or the target should move into chrome.  I think that having project
> files reach across the tree like this is freaky.

Same as above.

[jianli, 2009-04-10 19:49:06]

LGTM.