webkit/fileapi/file_system_operation.h - Issue 6604020: Introduce FileSystemFileUtil and -Proxy to decorate base::file_util in webkit/fileapi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_operation.h

Issue 6604020: Introduce FileSystemFileUtil and -Proxy to decorate base::file_util in webkit/fileapi. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Reflected comments. Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webkit/fileapi/file_system_file_util_proxy.cc ('K') | « webkit/fileapi/file_system_file_util_proxy.cc ('k') | webkit/fileapi/file_system_operation.cc » ('j') | webkit/fileapi/file_system_operation.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/fileapi/file_system_operation.h

diff --git a/webkit/fileapi/file_system_operation.h b/webkit/fileapi/file_system_operation.h

index 6542806853b47ecdf422b4f815d4a383331a870f..d2e5223986cb0f58eb24ebc7de16492e54f33f4d 100644

--- a/webkit/fileapi/file_system_operation.h

+++ b/webkit/fileapi/file_system_operation.h

@@ -32,6 +32,7 @@ namespace fileapi {

class FileSystemCallbackDispatcher;

class FileSystemContext;

+class FileSystemOperationContext;

class FileWriterDelegate;

// This class is designed to serve one-time file system operation per instance.

@@ -55,7 +56,7 @@ class FileSystemOperation {

bool exclusive);

void CreateDirectory(const FilePath& path,

bool exclusive,

- bool recursive);

+ bool);

kinuko 2011/03/03 21:29:22 I'd like to keep this signature as is until we cle

Dai Mikurube (google.com) 2011/03/03 22:19:10 Done. Replied in file_system_operation.cc.

void Copy(const FilePath& src_path,

const FilePath& dest_path);

void Move(const FilePath& src_path,

@@ -172,6 +173,7 @@ class FileSystemOperation {

scoped_ptr<FileSystemCallbackDispatcher> dispatcher_;

scoped_refptr<FileSystemContext> file_system_context_;

+ scoped_ptr<FileSystemOperationContext> file_system_operation_context_;

base::ScopedCallbackFactory<FileSystemOperation> callback_factory_;