Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 6604002: Remove some more uses of subgraphs and more cleanup of the graph builder. (Closed)

Created:
9 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Remove some more uses of subgraphs and more cleanup of the graph builder. Do not use subgraphs to implement the translation of simple branching control flow, for the function body entry, or for labeled blocks. Combine all the loop construction functions into a single one. Resolve a possible problem with duplicate AST IDs used both for joined loop break blocks, the normal loop exit, and for their common successor, by never introducing the extra (successor) block and instead making the normal loop exit a predecessor of the break join block. There is a similar issue with joined continue blocks. Remove a (never needed) two-element zone list per each time we replace one hydrogen value with another. Committed: http://code.google.com/p/v8/source/detail?r=7027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -237 lines) Patch
M src/hydrogen.h View 4 chunks +15 lines, -19 lines 0 comments Download
M src/hydrogen.cc View 15 chunks +167 lines, -207 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 9 months ago (2011-03-02 12:32:43 UTC) #1
fschneider
9 years, 9 months ago (2011-03-02 13:24:21 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698