Issue 660395: [Mac] Save window position into the SessionService, so we can restore it afte...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660395: [Mac] Save window position into the SessionService, so we can restore it afte... (Closed)

Created:
10 years, 9 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Save window position into the SessionService, so we can restore it after a crash. BUG=20909 TEST=Start chrome, load some pages/tabs, move the window somewhere else. Click away and back to the window (to trigger saving window position). Kill chrome (you may have to use kill -9 to actually kill it uncleanly). Restart, click to restore pages. Window should jump to where it was before the crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41248

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/browser_window_controller_private.mm	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

Nothing too exciting, code copied from browser_window_gtk.cc. I spent a while trying to mock out ...

10 years, 9 months ago (2010-03-02 20:57:54 UTC) #1

viettrungluu

So are you planning on committing this any time soon, or shall I?

10 years, 9 months ago (2010-03-11 02:08:57 UTC) #3

rohitrao (ping after 24h)

10 years, 9 months ago (2010-03-11 02:41:33 UTC) #4

On 2010/03/11 02:08:57, viettrungluu wrote:
> So are you planning on committing this any time soon, or shall I?

Ok, ok, committing.

Expand Messages | Collapse Messages