Issue 660375: Revert change to EquivalentTime in date.js. The checks that I've removed in t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660375: Revert change to EquivalentTime in date.js. The checks that I've removed in t... (Closed)

Created:
10 years, 9 months ago by Oleg Eterevsky

Modified:
9 years, 5 months ago

Reviewers:
antonm, Vitaly Repeshko, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert change to EquivalentTime in date.js. The checks that I've removed in the last changed were essential after all. Committed: http://code.google.com/p/v8/source/detail?r=3999

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	src/date-delay.js	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
	M	src/runtime.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

http://codereview.chromium.org/660375/diff/7/1002 File src/runtime.cc (right): http://codereview.chromium.org/660375/diff/7/1002#newcode4971 src/runtime.cc:4971: Just an idea: Does it make sense to assert ...

10 years, 9 months ago (2010-03-02 14:01:19 UTC) #2

antonm

LGTM http://codereview.chromium.org/660375/diff/7/1002 File src/runtime.cc (right): http://codereview.chromium.org/660375/diff/7/1002#newcode4947 src/runtime.cc:4947: ASSERT(args[0]->IsSmi()); I think we should either have ASSERTs ...

10 years, 9 months ago (2010-03-02 14:07:53 UTC) #3

Oleg Eterevsky

10 years, 9 months ago (2010-03-02 14:16:17 UTC) #4

http://codereview.chromium.org/660375/diff/7/1002
File src/runtime.cc (right):

http://codereview.chromium.org/660375/diff/7/1002#newcode4947
src/runtime.cc:4947: ASSERT(args[0]->IsSmi());
On 2010/03/02 14:07:53, antonm wrote:
> I think we should either have ASSERTs and use Smi::cast or
CONVERT_SMI_CHECKED.

I've removed the ASSERTs.

http://codereview.chromium.org/660375/diff/7/1002#newcode4971
src/runtime.cc:4971: 
On 2010/03/02 14:01:19, Vitaly wrote:
> Just an idea: Does it make sense to assert 'month' is in the valid range here?

Done.

Expand Messages | Collapse Messages

Issue 660375: Revert change to EquivalentTime in date.js. The checks that I've removed in t... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages