Issue 660310: Fix a typo in the RSA benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660310: Fix a typo in the RSA benchmark. (Closed)

Created:
10 years, 9 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Fix a typo in the RSA benchmark. Also fix error handling in RSAPublicKeyFromBuf(). BUG=1210 TEST=none

Patch Set 2 : Follow output convention. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/platform/vboot_reference/tests/rsa_verify_benchmark.c	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
	M	src/platform/vboot_reference/utils/file_keys.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM but address the comment (possibly in a separate CL). http://codereview.chromium.org/660310/diff/1/2 File src/platform/vboot_reference/tests/rsa_verify_benchmark.c (right): http://codereview.chromium.org/660310/diff/1/2#newcode77 ...

10 years, 9 months ago (2010-03-01 22:10:12 UTC) #2

gauravsh

10 years, 9 months ago (2010-03-01 22:26:18 UTC) #3

Submitting...

http://codereview.chromium.org/660310/diff/1/2
File src/platform/vboot_reference/tests/rsa_verify_benchmark.c (right):

http://codereview.chromium.org/660310/diff/1/2#newcode77
src/platform/vboot_reference/tests/rsa_verify_benchmark.c:77: fprintf(stdout,
"rsa%d/%s:%.02f\n", key_size, sha_strings[algorithm], msecs);
On 2010/03/01 22:10:15, petkov wrote:
> Does this become the key name in the keyval autotest pairs? If so, can you
> follow the convention (either here, on in the py wrapper) -- all lower case,
> underscores, start with units (e.g, ms_rsa<size>_<alg>)
> 
Yes. Done.

Expand Messages | Collapse Messages

Issue 660310: Fix a typo in the RSA benchmark. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Follow output convention. #

Messages