webkit/fileapi/file_system_util.h - Issue 6603034: Stop returning the true root path of each filesystem from openFileSystem....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/fileapi/file_system_util.h

Issue 6603034: Stop returning the true root path of each filesystem from openFileSystem.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« webkit/fileapi/file_system_path_manager.cc ('K') | « webkit/fileapi/file_system_usage_tracker_unittest.cc ('k') | webkit/fileapi/file_system_util.cc » ('j') | webkit/fileapi/file_system_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_UTIL_H_	5 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_UTIL_H_

6 #define WEBKIT_FILEAPI_FILE_SYSTEM_UTIL_H_	6 #define WEBKIT_FILEAPI_FILE_SYSTEM_UTIL_H_

7 #pragma once	7 #pragma once

8	8

9 #include "webkit/fileapi/file_system_types.h"	9 #include "webkit/fileapi/file_system_types.h"

10	10

11 class FilePath;	11 class FilePath;

12 class GURL;	12 class GURL;

13	13

14 namespace fileapi {	14 namespace fileapi {

15	15

	16 // The file_path this returns will be using '/' as a path separator, no matter

	17 // what platform you're on.

16 bool CrackFileSystemURL(const GURL& url, GURL* origin_url, FileSystemType* type,	18 bool CrackFileSystemURL(const GURL& url, GURL* origin_url, FileSystemType* type,

17 FilePath* file_path);	19 FilePath* file_path);

18	20

	21 GURL GetFileSystemRootURI(const GURL& origin_url, fileapi::FileSystemType type);
	kinuko 2011/03/14 11:03:57 When we use URL but not URI (or vice versa)? When we use URL but not URI (or vice versa)? ericu 2011/03/15 02:43:11 Ian Hickson suggested that the whole spec switch t Show quoted text On 2011/03/14 11:03:57, kinuko wrote: > When we use URL but not URI (or vice versa)? Ian Hickson suggested that the whole spec switch to URL to match the rest of the web platform better. Once I bring that up on-list and put it into the spec, we should change everything. I'll try to do that this week, so that we can fix the API before Chrome 12. kinuko 2011/03/16 19:33:38 Thanks, sgtm. Show quoted text On 2011/03/15 02:43:11, ericu wrote: > On 2011/03/14 11:03:57, kinuko wrote: > > When we use URL but not URI (or vice versa)? > > Ian Hickson suggested that the whole spec switch to URL to match the rest of the > web platform better. Once I bring that up on-list and put it into the spec, we > should change everything. I'll try to do that this week, so that we can fix the > API before Chrome 12. Thanks, sgtm. ericu 2011/03/16 23:47:31 I've now made and announced this spec change, and Show quoted text On 2011/03/15 02:43:11, ericu wrote: > On 2011/03/14 11:03:57, kinuko wrote: > > When we use URL but not URI (or vice versa)? > > Ian Hickson suggested that the whole spec switch to URL to match the rest of the > web platform better. Once I bring that up on-list and put it into the spec, we > should change everything. I'll try to do that this week, so that we can fix the > API before Chrome 12. I've now made and announced this spec change, and logged a webkit bug for the interface change.
	22

19 } // namespace fileapi	23 } // namespace fileapi

20	24

21 #endif // WEBKIT_FILEAPI_FILE_SYSTEM_UTIL_H_	25 #endif // WEBKIT_FILEAPI_FILE_SYSTEM_UTIL_H_

OLD	NEW