Stop returning the true root path of each filesystem from openFileSystem....

webkit/fileapi/file_system_operation_context.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_OPERATION_CONTEXT_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_OPERATION_CONTEXT_H_
 
+#include "base/ref_counted.h"
+#include "googleurl/src/gurl.h"
 #include "webkit/fileapi/file_system_file_util.h"
+#include "webkit/fileapi/file_system_types.h"
 
 namespace fileapi {
 
+class FileSystemContext;
+
 class FileSystemOperationContext {
  public:
-  FileSystemOperationContext(FileSystemFileUtil* file_system_file_util)
-      : file_system_file_util_(file_system_file_util) {
+  FileSystemOperationContext(
+      FileSystemContext* context,
+      FileSystemFileUtil* file_system_file_util);
+
+  FileSystemContext* file_system_context() const {
+    return file_system_context_.get();
   }
 
   FileSystemFileUtil* file_system_file_util() const {
     return file_system_file_util_;
   }
 
+  void set_src_origin_url(const GURL& url) {
+    src_origin_url_ = url;
+  }
+
+  const GURL& src_origin_url() const {
+    return src_origin_url_;
+  }
+
+  GURL src_root_url() const;

[kinuko, 2011/03/14 11:03:57]

src_root_url() and get_root_url() are not single getters and I think they should
be in CamelCase.  Actually, I doubt if we need those methods in this class--
they can be created by calling a single function with public values of this
method, and having both {src,dest}_origin_url() and {src,dest}_root_url() is
confusing.
Do we really need them here?

[ericu, 2011/03/15 02:43:11]

Removed.  After fixing a bug, there was only one call left anyway.

+
+  void set_dest_origin_url(const GURL& url) {
+    dest_origin_url_ = url;
+  }
+
+  const GURL& dest_origin_url() const {
+    return dest_origin_url_;
+  }
+
+  GURL dest_root_url() const;
+
+  FileSystemType src_type() const {
+    return src_type_;
+  }
+
+  void set_src_type(FileSystemType src_type) {
+    src_type_ = src_type;
+  }
+
+  FileSystemType dest_type() const {
+    return dest_type_;
+  }
+
+  void set_dest_type(FileSystemType dest_type) {
+    dest_type_ = dest_type;
+  }
+
  private:
   // This file_system_file_util_ is not "owned" by FileSystemOperationContext.
   // It is supposed to be a pointer to a singleton.
+  scoped_refptr<FileSystemContext> file_system_context_;
   FileSystemFileUtil* file_system_file_util_;
+
+  GURL src_origin_url_;  // Also used for any single-path operation.
+  GURL dest_origin_url_;
+  FileSystemType src_type_;  // Also used for any single-path operation.
+  FileSystemType dest_type_;
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_OPERATION_CONTEXT_H_