Added link to ppb.h to point to list of valid interface names. Wrote/rewrote ...

Added link to ppb.h to point to list of valid interface names. Wrote/rewrote docs in ppb_image_data.h

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77548

[dmichael(do not use this one), 2011-03-04 16:42:49]

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb.h
File ppapi/c/ppb.h (right):

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb.h#newcode27
ppapi/c/ppb.h:27: * for a complete list of interface names.
I think I'd prefer an absolute URL, so that somebody looking at the code can
find it.

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h
File ppapi/c/ppb_image_data.h (right):

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h#newcode83
ppapi/c/ppb_image_data.h:83: * This value represents a pointer to a function
that returns the browser's
I thought the new wording being used elsewhere was slightly less verbose... 
something like:
'GetNativeImageDataFormat is a pointer to a function...'
I think that would be more readable.

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h#newcode85
ppapi/c/ppb_image_data.h:85: * browser uses internally for painting. Other
formats may require
Might read better as:  "The browser uses this format internally for painting."

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h#newcode94
ppapi/c/ppb_image_data.h:94: * This value represents a pointer to a function
that determines if the given
Ditto:  I think "<name of fucntion pointer> is a pointer to a function" reads
better.  (I suggest that for all of them, if you agree).

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h#newcod...
ppapi/c/ppb_image_data.h:118: * be sure to set all the pixels..
extra period

[jond, 2011-03-04 17:16:33]

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb.h
File ppapi/c/ppb.h (right):

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb.h#newcode27
ppapi/c/ppb.h:27: * for a complete list of interface names.
Done. The link won't work until we push the next load of docs to
code.google.com. 

On 2011/03/04 16:42:49, dmichael wrote:
> I think I'd prefer an absolute URL, so that somebody looking at the code can
> find it.

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h
File ppapi/c/ppb_image_data.h (right):

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h#newcode83
ppapi/c/ppb_image_data.h:83: * This value represents a pointer to a function
that returns the browser's
On 2011/03/04 16:42:49, dmichael wrote:
> I thought the new wording being used elsewhere was slightly less verbose... 
> something like:
> 'GetNativeImageDataFormat is a pointer to a function...'
> I think that would be more readable.

Done.

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h#newcode85
ppapi/c/ppb_image_data.h:85: * browser uses internally for painting. Other
formats may require
On 2011/03/04 16:42:49, dmichael wrote:
> Might read better as:  "The browser uses this format internally for painting."

Done.

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h#newcode94
ppapi/c/ppb_image_data.h:94: * This value represents a pointer to a function
that determines if the given
On 2011/03/04 16:42:49, dmichael wrote:
> Ditto:  I think "<name of fucntion pointer> is a pointer to a function" reads
> better.  (I suggest that for all of them, if you agree).

Done.

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb_image_data.h#newcod...
ppapi/c/ppb_image_data.h:118: * be sure to set all the pixels..
On 2011/03/04 16:42:49, dmichael wrote:
> extra period

Done.

[dmichael(do not use this one), 2011-03-04 19:45:01]

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb.h
File ppapi/c/ppb.h (right):

http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb.h#newcode27
ppapi/c/ppb.h:27: * for a complete list of interface names.
On 2011/03/04 17:16:33, jond wrote:
> Done. The link won't work until we push the next load of docs to
> http://code.google.com. 
> 
> On 2011/03/04 16:42:49, dmichael wrote:
> > I think I'd prefer an absolute URL, so that somebody looking at the code can
> > find it.
> 
Can you make doxygen still recognize it if you break it in to multiple lines? 
We generally don't have >80 characters per line.

[jond, 2011-03-04 20:09:27]

Yes. I fixed it.

- Jon

On Fri, Mar 4, 2011 at 12:45 PM, <dmichael@google.com> wrote:

>
> http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb.h
> File ppapi/c/ppb.h (right):
>
> http://codereview.chromium.org/6603029/diff/1/ppapi/c/ppb.h#newcode27
> ppapi/c/ppb.h:27: * for a complete list of interface names.
> On 2011/03/04 17:16:33, jond wrote:
>
>> Done. The link won't work until we push the next load of docs to
>> http://code.google.com.
>>
>
>  On 2011/03/04 16:42:49, dmichael wrote:
>> > I think I'd prefer an absolute URL, so that somebody looking at the
>>
> code can
>
>> > find it.
>>
>
> Can you make doxygen still recognize it if you break it in to multiple
> lines?  We generally don't have >80 characters per line.
>
> http://codereview.chromium.org/6603029/
>

[dmichael(do not use this one), 2011-03-04 20:41:41]

LGTM, assuming clean try