Issue 660299: Fix revinfo with git

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660299: Fix revinfo with git (Closed)

Created:
10 years, 9 months ago by Nasser Grainawi

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Visibility:
Public.

Description

Fix revinfo with git BUG=37104 BUG=chromium-os:1658 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40294

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -12 lines)			Patch
	M	gclient.py	View		3 chunks	+14 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Eh, the fix was fairly trivial, I should have realized. Thanks for doing this. It's ...

10 years, 9 months ago (2010-03-01 20:28:42 UTC) #2

Nasser Grainawi

10 years, 9 months ago (2010-03-01 20:38:18 UTC) #3

On 2010/03/01 20:28:42, Marc-Antoine Ruel wrote:
> Eh, the fix was fairly trivial, I should have realized. Thanks for doing this.
> It's still a shame it mostly dupes the code in RunOnDeps, do you think we
should
> merge them eventually? Probably in the "bah" priority though. :)

Yeah, somewhere around that priority level.
Really, gclient.py could use a wholesale refactoring.

> 
> Please use BUG=37104 and BUG=chromium-os:1658 since you're referring to a
> chromiumos bug. I'm not sure the second form works but we can try it out and
> see. :)

Doesn't look like BUG=chromium-os:### works, too bad.

> 
> LGTM.

Expand Messages | Collapse Messages