Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: src/api.cc

Issue 660267: Tweak the new context disposal GC heuristic to cleanly separate... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
===================================================================
--- src/api.cc (revision 3980)
+++ src/api.cc (working copy)
@@ -438,7 +438,7 @@
void V8::DisposeGlobal(i::Object** obj) {
LOG_API("DisposeGlobal");
if (!i::V8::IsRunning()) return;
- if ((*obj)->IsGlobalContext()) i::Heap::NotifyContextDisposed();
+ if ((*obj)->IsGlobalContext()) i::Heap::NotifyContextDisposedDeprecated();
i::GlobalHandles::Destroy(obj);
}
@@ -2823,7 +2823,7 @@
void v8::V8::ContextDisposedNotification() {
if (!i::V8::IsRunning()) return;
- i::Heap::CollectAllGarbageIfContextDisposed(true);
+ i::Heap::NotifyContextDisposed();
}
@@ -2863,7 +2863,7 @@
// decide when should make a full GC.
#else
// Give the heap a chance to cleanup if we've disposed contexts.
- i::Heap::CollectAllGarbageIfContextDisposed(false);
+ i::Heap::CollectAllGarbageIfContextDisposedDeprecated();
#endif
v8::Handle<ObjectTemplate> proxy_template = global_template;
i::Handle<i::FunctionTemplateInfo> proxy_constructor;
« no previous file with comments | « include/v8.h ('k') | src/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698