Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 660265: Add candidate_window chromeos_builder target. (Closed)

Created:
10 years, 9 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews_googlegroups.com, mazda, jiesun
Visibility:
Public.

Description

Add candidate_window to chromeos_builder target. This is to get back candidate_window binary in the snapshots of chromium for chromium os that can be found at http://build.chromium.org/buildbot/snapshots/chromium-rel-linux-chromiumos/ TEST=manually BUG=crosbug.com/1708 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40259

Patch Set 1 #

Total comments: 2

Patch Set 2 : get back the todo comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/all.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yusuke Sato
http://codereview.chromium.org/660265/diff/1/2 File build/all.gyp (right): http://codereview.chromium.org/660265/diff/1/2#newcode261 build/all.gyp:261: '../chrome/browser/chromeos/text_input/text_input.gyp:candidate_window' I'm not sure but should we keep the ...
10 years, 9 months ago (2010-03-01 06:50:27 UTC) #1
satorux1
http://codereview.chromium.org/660265/diff/1/2 File build/all.gyp (right): http://codereview.chromium.org/660265/diff/1/2#newcode261 build/all.gyp:261: '../chrome/browser/chromeos/text_input/text_input.gyp:candidate_window' On 2010/03/01 06:50:27, Yusuke Sato wrote: > I'm ...
10 years, 9 months ago (2010-03-01 06:52:16 UTC) #2
Yusuke Sato
10 years, 9 months ago (2010-03-01 07:18:50 UTC) #3
LGTM

On 2010/03/01 06:52:16, satorux1 wrote:
> http://codereview.chromium.org/660265/diff/1/2
> File build/all.gyp (right):
> 
> http://codereview.chromium.org/660265/diff/1/2#newcode261
> build/all.gyp:261:
> '../chrome/browser/chromeos/text_input/text_input.gyp:candidate_window'
> On 2010/03/01 06:50:27, Yusuke Sato wrote:
> > I'm not sure but should we keep the TODO comment? like: # TODO(jiesun):
should
> > we put session here?
> > 
> > (what is 'session'?)
> 
> Good catch. I don't know about session, but get back the comment just in case.

Powered by Google App Engine
This is Rietveld 408576698