Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 660257: Enable GC update for pointers in GenerateKeyedLoadICDebugBreak (Closed)
Patch Set: follow codereview Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 // -- ecx : name 139 // -- ecx : name
140 // -- edx : receiver 140 // -- edx : receiver
141 // ----------------------------------- 141 // -----------------------------------
142 Generate_DebugBreakCallHelper(masm, eax.bit() | ecx.bit() | edx.bit(), false); 142 Generate_DebugBreakCallHelper(masm, eax.bit() | ecx.bit() | edx.bit(), false);
143 } 143 }
144 144
145 145
146 void Debug::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 146 void Debug::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
147 // Register state for keyed IC load call (from ic-ia32.cc). 147 // Register state for keyed IC load call (from ic-ia32.cc).
148 // ----------- S t a t e ------------- 148 // ----------- S t a t e -------------
149 // No registers used on entry. 149 // -- edx : receiver
150 // -- eax : key
150 // ----------------------------------- 151 // -----------------------------------
151 Generate_DebugBreakCallHelper(masm, 0, false); 152 Generate_DebugBreakCallHelper(masm, eax.bit() | edx.bit(), false);
152 } 153 }
153 154
154 155
155 void Debug::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 156 void Debug::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
156 // Register state for keyed IC load call (from ic-ia32.cc). 157 // Register state for keyed IC load call (from ic-ia32.cc).
157 // ----------- S t a t e ------------- 158 // ----------- S t a t e -------------
158 // -- eax : value 159 // -- eax : value
160 // -- ecx : key
161 // -- edx : receiver
159 // ----------------------------------- 162 // -----------------------------------
160 // Register eax contains an object that needs to be pushed on the 163 // Register eax contains an object that needs to be pushed on the
161 // expression stack of the fake JS frame. 164 // expression stack of the fake JS frame.
162 Generate_DebugBreakCallHelper(masm, eax.bit(), false); 165 Generate_DebugBreakCallHelper(masm, eax.bit() | ecx.bit() | edx.bit(), false);
163 } 166 }
164 167
165 168
166 void Debug::GenerateCallICDebugBreak(MacroAssembler* masm) { 169 void Debug::GenerateCallICDebugBreak(MacroAssembler* masm) {
167 // Register state for keyed IC call call (from ic-ia32.cc) 170 // Register state for keyed IC call call (from ic-ia32.cc)
168 // ----------- S t a t e ------------- 171 // ----------- S t a t e -------------
169 // -- eax: number of arguments 172 // -- eax: number of arguments
170 // ----------------------------------- 173 // -----------------------------------
171 // The number of arguments in eax is not smi encoded. 174 // The number of arguments in eax is not smi encoded.
172 Generate_DebugBreakCallHelper(masm, 0, false); 175 Generate_DebugBreakCallHelper(masm, 0, false);
(...skipping 28 matching lines...) Expand all
201 // ----------------------------------- 204 // -----------------------------------
202 Generate_DebugBreakCallHelper(masm, 0, false); 205 Generate_DebugBreakCallHelper(masm, 0, false);
203 } 206 }
204 207
205 208
206 #undef __ 209 #undef __
207 210
208 #endif // ENABLE_DEBUGGER_SUPPORT 211 #endif // ENABLE_DEBUGGER_SUPPORT
209 212
210 } } // namespace v8::internal 213 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698