Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 660243: Small API improvements: (Closed)

Created:
10 years, 10 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Small API improvements: * Added Get and Set taking uint32_t for faster and more convenient access to elements. * Added less verbose casting for handles. Now instead of v8::Local<v8::String>::Cast(args[0]) one can write args[0].As<v8::String>(). Committed: http://code.google.com/p/v8/source/detail?r=4002

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -63 lines) Patch
M include/v8.h View 5 chunks +17 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M src/handles.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/handles.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +5 lines, -0 lines 1 comment Download
M test/cctest/test-api.cc View 20 chunks +74 lines, -63 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
10 years, 10 months ago (2010-02-27 14:29:58 UTC) #1
antonm
lgtm http://codereview.chromium.org/660243/diff/1/6 File src/runtime.cc (right): http://codereview.chromium.org/660243/diff/1/6#newcode2849 src/runtime.cc:2849: return GetElement(object, index); I am not sure it's ...
10 years, 10 months ago (2010-02-27 14:38:01 UTC) #2
Mads Ager (chromium)
10 years, 9 months ago (2010-03-02 09:56:38 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698