Issue 660240: Make sure SafeBrowsingResourceHandler overrides ResourceHandler::OnRequestClo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660240: Make sure SafeBrowsingResourceHandler overrides ResourceHandler::OnRequestClo... (Closed)

Created:
10 years, 10 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, Paul Godavari, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make sure SafeBrowsingResourceHandler overrides ResourceHandler::OnRequestClosed() so it doesn't inherit the default (unfortunately the base class doesn't define it as pure virtual). BUG=36964 TBR=rvargas Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40208

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/safe_browsing_resource_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/safe_browsing_resource_handler.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages