Issue 660236: Clearly identify extension and file:// resources in the cookie tree view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660236: Clearly identify extension and file:// resources in the cookie tree view. (Closed)

Created:
10 years, 10 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
dumi

CC:
chromium-reviews, ben+cc_chromium.org, jochen (gone - plz use gerrit)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Clearly identify extension and file:// resources in the cookie tree view. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40205

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -22 lines)			Patch
M	chrome/browser/browsing_data_database_helper.h	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.cc	View	7 chunks	+58 lines, -22 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaeln

http://codereview.chromium.org/660236/diff/1/4 File chrome/browser/cookies_tree_model.cc (right): http://codereview.chromium.org/660236/diff/1/4#newcode530 chrome/browser/cookies_tree_model.cc:530: UTF8ToWide(extension->name()) : l10n_util::GetString(IDS_UNKNOWN_PLUGIN_NAME); line length is fixed locally

10 years, 10 months ago (2010-02-27 02:37:56 UTC) #2

LGTM!

Expand Messages | Collapse Messages