|
"/b/slave/chromium-rel-linux/build/src/gpu/command_buffer/client/gles2_demo_cc.cc:50:warning: 'length' may be used uninitialized in this function"
Revert 40193 - Added support for glGetString, glGetShaderSource,
glGetProgramInfoLog and glGetShaderInfoLog
This turned up lots of issues.
* glGetShaderiv needed to be wrapped so it
returns the size of the shader the user passed
in. Not the munged shader sent to GL.
* Another issue that came up is that client
side validation is needed to ensure that
the client side GLES2Implementation does not
generate bad commands. For example, calling
glUniform1iv with a negative count would
generate a bad command. The service side
would see that and think the program was
malicious and stop processing commands.
So, that means I had to add some client side
validation and wrap glGetError on the client
side so I can synthisize GL errors there.
TEST=lots of unit tests.
BUG=none
Review URL: http://codereview.chromium.org/661220
TBR=gman@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40198
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+559 lines, -747 lines) |
Patch |
 |
M |
gpu/command_buffer/build_gles2_cmd_buffer.py
|
View
|
|
23 chunks |
+72 lines, -207 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/client/gles2_cmd_helper_autogen.h
|
View
|
|
3 chunks |
+23 lines, -8 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/client/gles2_implementation.h
|
View
|
|
4 chunks |
+4 lines, -19 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/client/gles2_implementation.cc
|
View
|
|
16 chunks |
+26 lines, -133 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/client/gles2_implementation_autogen.h
|
View
|
|
10 chunks |
+21 lines, -115 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/common/GLES2/gl2types.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/common/gles2_cmd_format.h
|
View
|
|
4 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/common/gles2_cmd_format_autogen.h
|
View
|
|
12 chunks |
+107 lines, -52 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
|
View
|
|
3 chunks |
+31 lines, -9 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/common/gles2_cmd_utils.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/common/gles2_cmd_utils.cc
|
View
|
|
2 chunks |
+0 lines, -46 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/common_decoder.h
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/common_decoder.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/gles2_cmd_decoder.cc
|
View
|
|
7 chunks |
+52 lines, -32 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
|
View
|
|
4 chunks |
+75 lines, -22 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
|
View
|
|
4 chunks |
+13 lines, -14 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h
|
View
|
|
3 chunks |
+11 lines, -63 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h
|
View
|
|
16 chunks |
+119 lines, -6 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|