[crosutils] Add --quiet to cros_run_parallel_vm_tests

[crosutils] Add --quiet to cros_run_parallel_vm_tests

When running tests that generate huge amounts of output (like
desktopui_BrowserTest) it would be nice to suppress stdout and stderr
so that the buildbot logs aren't enormous.  Adding a --quiet flag that
requires the --results_dir_root flag ensures that we can trim the
output while still ensuring that the useful data is captured.

BUG=8544
TEST=run two tests in parallel with --quiet and --results_dir_root and see that the output is where you expect it

Change-Id: I25c7ad2bc1d017a30df0d1ad4604207443e711d7

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2eae7c2

[petkov, 2011-03-02 23:08:34]

it's functionally correct :-)

a few nits/suggestions, LGTM otherwise.

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests.py
File bin/cros_run_parallel_vm_tests.py (right):

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests....
bin/cros_run_parallel_vm_tests.py:54: self._quiet = quiet
document quiet too?

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests....
bin/cros_run_parallel_vm_tests.py:78: results_dir = '%s/%s.%d' %
(self._results_dir_root, test, ssh_port)
subtle... it took me a while to think through the case. i guess this is OK as
is, although you might want to initialize results_dir to None here and set it to
the right value in the if body below.

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests....
bin/cros_run_parallel_vm_tests.py:88: if self._quiet:
can you move this up and do "elif self._order_output"

I know order_output is forced to false but it will be even more clear that way,
I think.

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests....
bin/cros_run_parallel_vm_tests.py:90: Info('Output is in %s' % results_dir)
You mean the log files are there?

[Chris Masone, 2011-03-02 23:27:28]

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests.py
File bin/cros_run_parallel_vm_tests.py (right):

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests....
bin/cros_run_parallel_vm_tests.py:54: self._quiet = quiet
On 2011/03/02 23:08:34, petkov wrote:
> document quiet too?

Done.

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests....
bin/cros_run_parallel_vm_tests.py:78: results_dir = '%s/%s.%d' %
(self._results_dir_root, test, ssh_port)
On 2011/03/02 23:08:34, petkov wrote:
> subtle... it took me a while to think through the case. i guess this is OK as
> is, although you might want to initialize results_dir to None here and set it
to
> the right value in the if body below.

Done.

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests....
bin/cros_run_parallel_vm_tests.py:88: if self._quiet:
On 2011/03/02 23:08:34, petkov wrote:
> can you move this up and do "elif self._order_output"
> 
> I know order_output is forced to false but it will be even more clear that
way,
> I think.

Done.

http://codereview.chromium.org/6602098/diff/1/bin/cros_run_parallel_vm_tests....
bin/cros_run_parallel_vm_tests.py:90: Info('Output is in %s' % results_dir)
On 2011/03/02 23:08:34, petkov wrote:
> You mean the log files are there?

Yes.

[petkov, 2011-03-02 23:30:00]

LGTM