src/x64/macro-assembler-x64.cc - Issue 6602081: Stop using plain Arrays internally in built-in functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 6602081: Stop using plain Arrays internally in built-in functions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Changed header in bootstrapper.cc Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 8845bbb77cc33d11a55b8756dc83d7b3e3de4ca5..cdd96e2a534c144c1ab06542bdffa6ea2ece95c6 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -908,7 +908,7 @@ Condition MacroAssembler::CheckSmi(const Operand& src) {

Condition MacroAssembler::CheckNonNegativeSmi(Register src) {

ASSERT_EQ(0, kSmiTag);

- // Make mask 0x8000000000000001 and test that both bits are zero.

+ // Test that both bits of the mask 0x8000000000000001 are zero.

movq(kScratchRegister, src);

rol(kScratchRegister, Immediate(1));

testb(kScratchRegister, Immediate(3));

« no previous file with comments | « src/x64/builtins-x64.cc ('k') | no next file » | no next file with comments »