Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Side by Side Diff: src/arm/builtins-arm.cc

Issue 6602081: Stop using plain Arrays internally in built-in functions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Changed header in bootstrapper.cc Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/array.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 // -- r0 : number of arguments 421 // -- r0 : number of arguments
422 // -- lr : return address 422 // -- lr : return address
423 // -- sp[...]: constructor arguments 423 // -- sp[...]: constructor arguments
424 // ----------------------------------- 424 // -----------------------------------
425 Label generic_array_code, one_or_more_arguments, two_or_more_arguments; 425 Label generic_array_code, one_or_more_arguments, two_or_more_arguments;
426 426
427 // Get the Array function. 427 // Get the Array function.
428 GenerateLoadArrayFunction(masm, r1); 428 GenerateLoadArrayFunction(masm, r1);
429 429
430 if (FLAG_debug_code) { 430 if (FLAG_debug_code) {
431 // Initial map for the builtin Array function shoud be a map. 431 // Initial map for the builtin Array functions should be maps.
432 __ ldr(r2, FieldMemOperand(r1, JSFunction::kPrototypeOrInitialMapOffset)); 432 __ ldr(r2, FieldMemOperand(r1, JSFunction::kPrototypeOrInitialMapOffset));
433 __ tst(r2, Operand(kSmiTagMask)); 433 __ tst(r2, Operand(kSmiTagMask));
434 __ Assert(ne, "Unexpected initial map for Array function"); 434 __ Assert(ne, "Unexpected initial map for Array function");
435 __ CompareObjectType(r2, r3, r4, MAP_TYPE); 435 __ CompareObjectType(r2, r3, r4, MAP_TYPE);
436 __ Assert(eq, "Unexpected initial map for Array function"); 436 __ Assert(eq, "Unexpected initial map for Array function");
437 } 437 }
438 438
439 // Run the native code for the Array function called as a normal function. 439 // Run the native code for the Array function called as a normal function.
440 ArrayNativeCode(masm, &generic_array_code); 440 ArrayNativeCode(masm, &generic_array_code);
441 441
(...skipping 1177 matching lines...) Expand 10 before | Expand all | Expand 10 after
1619 __ bind(&dont_adapt_arguments); 1619 __ bind(&dont_adapt_arguments);
1620 __ Jump(r3); 1620 __ Jump(r3);
1621 } 1621 }
1622 1622
1623 1623
1624 #undef __ 1624 #undef __
1625 1625
1626 } } // namespace v8::internal 1626 } } // namespace v8::internal
1627 1627
1628 #endif // V8_TARGET_ARCH_ARM 1628 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/array.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698