Issue 6602077: Remove superfluous security check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6602077: Remove superfluous security check (Closed)

Created:
9 years, 9 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
Hung-Te, Will Drewry, David James, petkov, adlr, rchenna1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/memento_softwareupdate.git@master

Visibility:
Public.

Remove superfluous security check BUG=chrome-os-partner:2242 TEST=will test Change-Id: Id1e8606b77cc2787914456dc0ef7e7caa55d434d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=db6097c

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -63 lines)			Patch
	M	find_omaha.sh	View		2 chunks	+4 lines, -63 lines	0 comments	Download

Total messages: 8 (0 generated)

Nick Sanders

This is only used in factory install now. I think the root permissions check is ...

9 years, 9 months ago (2011-03-02 06:27:05 UTC) #1

Nick Sanders

This is ultra critical. It's going in today unless someone yells.

9 years, 9 months ago (2011-03-02 21:57:50 UTC) #2

rchenna1

On 2011/03/02 22:14:42, Will Drewry wrote: > As per the out of band discussion, LGTM ...

9 years, 9 months ago (2011-03-02 22:16:41 UTC) #6

Will Drewry

Why is this check a blocker? On Wed, Mar 2, 2011 at 3:57 PM, <nsanders@chromium.org> ...

9 years, 9 months ago (2011-03-02 22:24:55 UTC) #7

Nick Sanders

9 years, 9 months ago (2011-03-03 04:16:28 UTC) #8

This seems to cause weird problems in buildbot generated images.