Kill CleanUpAfterMessageLoopDestruction.

Kill CleanUpAfterMessageLoopDestruction.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76800

[eroman, 2011-03-02 02:23:31]

Can you give me some more context on this change?

http://codereview.chromium.org/6602047/diff/1/chrome/browser/browser_process_...
File chrome/browser/browser_process_sub_thread.cc (right):

http://codereview.chromium.org/6602047/diff/1/chrome/browser/browser_process_...
chrome/browser/browser_process_sub_thread.cc:32: delete notification_service_;
hopefully there aren't any destruction observers that indirectly access the
notification service, otherwise they will now be accessing deleted memory... man
i hate the destruction observers :)

http://codereview.chromium.org/6602047/diff/1/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (right):

http://codereview.chromium.org/6602047/diff/1/chrome/browser/io_thread.cc#new...
chrome/browser/io_thread.cc:443:
base::debug::LeakTracker<net::URLRequest>::CheckForLeaks();
What has changed to make this safe?

If I remember correctly, this had to be done in
CleanupAfterMessageLoopDestruction because URLFetcher was releasing its
URLRequest from a destruction observer on the IO thread (and the destruction
observers don't run until AFTER CleanUp().

[willchan no longer on Chromium, 2011-03-02 05:31:16]

http://codereview.chromium.org/6602047/diff/1/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (right):

http://codereview.chromium.org/6602047/diff/1/chrome/browser/io_thread.cc#new...
chrome/browser/io_thread.cc:443:
base::debug::LeakTracker<net::URLRequest>::CheckForLeaks();
On 2011/03/02 02:23:31, eroman wrote:
> What has changed to make this safe?
> 
> If I remember correctly, this had to be done in
> CleanupAfterMessageLoopDestruction because URLFetcher was releasing its
> URLRequest from a destruction observer on the IO thread (and the destruction
> observers don't run until AFTER CleanUp().

http://code.google.com/p/chromium/issues/detail?id=59630 documents how I fixed
them all. I think you reviewed most of those changes :)

If you search for DestructionObserver, you'll see that all the URLRequest
related ones are gone now.

[eroman, 2011-03-02 20:09:38]

Oh right, i forgot about that change.

LGTM then!

[commit-bot: I haz the power, 2011-03-03 18:12:20]

Failed to apply the patch.
svn: Commit failed (details follow):
svn:
'/mnt/data/b/commit-queue/workdir/chromium/remoting/host/user_authenticator_mac.h'
is scheduled for addition, but is missing

[willchan no longer on Chromium, 2011-03-03 18:22:02]

maruel: Any idea what's up with this? Doesn't look related to my cl at
all. Maybe I should just commit manually.

On Thu, Mar 3, 2011 at 10:12 AM,  <commit-bot@chromium.org> wrote:
> Failed to apply the patch.
> svn: Commit failed (details follow):
> svn:
>
'/mnt/data/b/commit-queue/workdir/chromium/remoting/host/user_authenticator_mac.h'
> is scheduled for addition, but is missing
>
>
> http://codereview.chromium.org/6602047/
>

[M-A Ruel, 2011-03-03 18:26:44]

On 2011/03/03 18:22:02, willchan wrote:
> maruel: Any idea what's up with this? Doesn't look related to my cl at
> all. Maybe I should just commit manually.
> 
> On Thu, Mar 3, 2011 at 10:12 AM,  <mailto:commit-bot@chromium.org> wrote:
> > Failed to apply the patch.
> > svn: Commit failed (details follow):
> > svn:
> >
>
'/mnt/data/b/commit-queue/workdir/chromium/remoting/host/user_authenticator_mac.h'
> > is scheduled for addition, but is missing
> >
> >
> > http://codereview.chromium.org/6602047/
> >

Wouha, seems like the revert from a previous commit failed. Will look into it.

[willchan no longer on Chromium, 2011-03-03 18:35:21]

On Thu, Mar 3, 2011 at 10:26 AM,  <maruel@chromium.org> wrote:
> On 2011/03/03 18:22:02, willchan wrote:
>>
>> maruel: Any idea what's up with this? Doesn't look related to my cl at
>> all. Maybe I should just commit manually.
>
>> On Thu, Mar 3, 2011 at 10:12 AM,  <mailto:commit-bot@chromium.org> wrote:
>> > Failed to apply the patch.
>> > svn: Commit failed (details follow):
>> > svn:
>> >
>
>
'/mnt/data/b/commit-queue/workdir/chromium/remoting/host/user_authenticator_mac.h'
>>
>> > is scheduled for addition, but is missing
>> >
>> >
>> > http://codereview.chromium.org/6602047/
>> >
>
> Wouha, seems like the revert from a previous commit failed. Will look into
> it.

Thanks! Just to confirm, should I just sit tight and you'll re-trigger
the commit bot when appropriate? I'm in no hurry.

>
> http://codereview.chromium.org/6602047/
>

[commit-bot: I haz the power, 2011-03-03 19:02:21]

Try job failure for 6602047-1 on linux:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...

[willchan no longer on Chromium, 2011-03-03 19:16:47]

Looks like a broken trybot. What do I as a commit-bot user do here?
Uncheck and check again?

On Thu, Mar 3, 2011 at 11:02 AM,  <commit-bot@chromium.org> wrote:
> Try job failure for 6602047-1 on linux:
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...
>
> http://codereview.chromium.org/6602047/
>

[commit-bot: I haz the power, 2011-03-03 20:40:36]

Change committed as 76800