Issue 6602031: Translate loops without using subgraphs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6602031: Translate loops without using subgraphs. (Closed)

Created:
9 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Translate loops without using subgraphs. Build all loop graphs without using class HSubgraph. This also eliminates a silly goto for the update expression of a for loop. Support for peeling loops is removed because it's currently untested. Committed: http://code.google.com/p/v8/source/detail?r=7017

Patch Set 1 #

Total comments: 4

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -176 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/hydrogen.h	View	3 chunks	+4 lines, -11 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+103 lines, -164 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM! http://codereview.chromium.org/6602031/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/6602031/diff/1/src/hydrogen.cc#newcode512 src/hydrogen.cc:512: HBasicBlock* HGraphBuilder::CreateEndless(IterationStatement* statement, Maybe it's possible to unify ...

9 years, 9 months ago (2011-03-02 10:45:35 UTC) #2

Kevin Millikin (Chromium)

9 years, 9 months ago (2011-03-02 11:08:42 UTC) #3

http://codereview.chromium.org/6602031/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6602031/diff/1/src/hydrogen.cc#newcode512
src/hydrogen.cc:512: HBasicBlock*
HGraphBuilder::CreateEndless(IterationStatement* statement,
On 2011/03/02 10:45:35, fschneider wrote:
> Maybe it's possible to unify CreateEndless/CreateDoWhile/CreateWhile.

Great idea, I'll do it as a separate change.

http://codereview.chromium.org/6602031/diff/1/src/hydrogen.cc#newcode2734
src/hydrogen.cc:2734: // TODO(fschneider): Implement peeling for endless loops
as well.
On 2011/03/02 10:45:35, fschneider wrote:
> This comment can go away now.

Yeah, you're right.

Expand Messages | Collapse Messages