Issue 660202: Modify autox deps to install correctly from ebuild and fix AutoLogin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660202: Modify autox deps to install correctly from ebuild and fix AutoLogin (Closed)

Created:
10 years, 10 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Modify autox deps to install correctly from ebuild and fix AutoLogin

Patch Set 1 #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -28 lines)			Patch
M	client/deps/autox/autox.py	View	1 chunk	+6 lines, -25 lines	2 comments	Download
M	client/site_tests/system_AutoLogin/control	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	client/site_tests/system_AutoLogin/system_AutoLogin.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 10 months ago (2010-02-26 21:59:44 UTC) #3

LGTM with a couple of (optional) nits.

http://codereview.chromium.org/660202/diff/1/2
File client/deps/autox/autox.py (right):

http://codereview.chromium.org/660202/diff/1/2#newcode7
client/deps/autox/autox.py:7: import common, commands, logging, os
Is common needed?

http://codereview.chromium.org/660202/diff/1/2#newcode14
client/deps/autox/autox.py:14: [status, output] = commands.getstatusoutput(
Maybe use shutils.copytree instead?

Expand Messages | Collapse Messages