Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 6602017: Merge 75787 - Improved memory usage while applying patch.... (Closed)

Created:
9 years, 9 months ago by kerz_chromium
Modified:
9 years, 7 months ago
Reviewers:
sra
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 75787 - Improved memory usage while applying patch. Reduced total size of allocations from 520MB to 318MB. The general technique is to allocate the correct size rather than grow into the correct size and overshoot. 1. Find file sizes and allocate buffers of that size for the input files. 2. Pre-allocate a buffer for the collected inputs for the final diff. 3. Calculate the size for (2) during compression and include it in the patch header. The courgette.exe command line tool now calls the same ApplyEnsemblePatch entry point that is called by the installer. This ensures measurements of courgette.exe are a better reflection of the installer. BUG=72459 Review URL: http://codereview.chromium.org/6546008 TBR=sra@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -16 lines) Patch
M courgette/courgette_tool.cc View 2 chunks +42 lines, -10 lines 0 comments Download
M courgette/ensemble.h View 2 chunks +2 lines, -1 line 0 comments Download
M courgette/ensemble_apply.cc View 7 chunks +20 lines, -1 line 0 comments Download
M courgette/ensemble_create.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M courgette/streams.h View 3 chunks +10 lines, -2 lines 0 comments Download
M courgette/streams.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
9 years, 9 months ago (2011-02-28 22:50:28 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698