Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6164)

Unified Diff: chrome/browser/ui/browser.cc

Issue 6602010: Added "--login-user=" option for the Guest session. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos/login
Patch Set: merge Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/tab_restore_service.cc ('k') | chrome/browser/ui/browser_init.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 66c99a2a06206f443c04e0aa9a76f49c483ecd12..7e030db54fc323e08e504d5c94914cdd2813827d 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1308,10 +1308,8 @@ void Browser::OpenCurrentURL() {
TabStripModel::ADD_FORCE_INDEX | TabStripModel::ADD_INHERIT_OPENER;
browser::Navigate(&params);
- // TODO: the ExtensionService should never be NULL, but in some cases it is,
- // see bug 73768. After it is resolved, the explicit test can go away.
- ExtensionService* service = profile_->GetExtensionService();
- if (service && service->IsInstalledApp(url)) {
+ DCHECK(profile_->GetExtensionService());
+ if (profile_->GetExtensionService()->IsInstalledApp(url)) {
UMA_HISTOGRAM_ENUMERATION(extension_misc::kAppLaunchHistogram,
extension_misc::APP_LAUNCH_OMNIBOX_LOCATION,
extension_misc::APP_LAUNCH_BUCKET_BOUNDARY);
@@ -3517,10 +3515,8 @@ void Browser::CommitInstant(TabContentsWrapper* preview_contents) {
instant_unload_handler_->RunUnloadListenersOrDestroy(old_contents, index);
GURL url = preview_contents->tab_contents()->GetURL();
- // TODO: the ExtensionService should never be NULL, but in some cases it is,
- // see bug 73768. After it is resolved, the explicit test can go away.
- ExtensionService* service = profile_->GetExtensionService();
- if (service && service->IsInstalledApp(url)) {
+ DCHECK(profile_->GetExtensionService());
+ if (profile_->GetExtensionService()->IsInstalledApp(url)) {
UMA_HISTOGRAM_ENUMERATION(extension_misc::kAppLaunchHistogram,
extension_misc::APP_LAUNCH_OMNIBOX_INSTANT,
extension_misc::APP_LAUNCH_BUCKET_BOUNDARY);
« no previous file with comments | « chrome/browser/sessions/tab_restore_service.cc ('k') | chrome/browser/ui/browser_init.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698