Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6602010: Added "--login-user=" option for the Guest session. (Closed)

Created:
9 years, 9 months ago by altimofeev
Modified:
9 years, 7 months ago
Reviewers:
Dmitry Polukhin, piman
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Added "--login-user=" option for the Guest session. Fixes regression which happened after http://codereview.chromium.org/6272016. BUG=chromium-os:12236, chromium-os:12568, chromium-os:12319 TEST=try to set theme in the guest session. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76519

Patch Set 1 #

Patch Set 2 : fixed browsertest #

Patch Set 3 : use DCHECK for GetExtensionsService #

Patch Set 4 : merged with trunk #

Patch Set 5 : added DCHECKs #

Patch Set 6 : merge #

Patch Set 7 : merge #

Patch Set 8 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -39 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 3 4 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest_chromeos.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.cc View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/app_launcher_handler.cc View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
altimofeev
9 years, 9 months ago (2011-02-28 17:22:53 UTC) #1
Dmitry Polukhin
LGTM but please fix failed test before commit.
9 years, 9 months ago (2011-02-28 19:10:30 UTC) #2
Dmitry Polukhin
Please also remove checks for extensions service is NULL (or make them DCHECK) introduced in ...
9 years, 9 months ago (2011-03-01 07:45:16 UTC) #3
altimofeev
I have Softly reverted http://codereview.chromium.org/6544023 and added DCHECKs.
9 years, 9 months ago (2011-03-01 13:03:47 UTC) #4
Dmitry Polukhin
LGMT
9 years, 9 months ago (2011-03-01 13:48:16 UTC) #5
piman
So with this revert, now the browser crashes again (with the DCHECK).
9 years, 9 months ago (2011-03-02 21:58:10 UTC) #6
altimofeev
9 years, 9 months ago (2011-03-03 08:10:28 UTC) #7 
On 2011/03/02 21:58:10, piman wrote:
> So with this revert, now the browser crashes again (with the DCHECK).

I have answered by comment in
http://code.google.com/p/chromium/issues/detail?id=73658.

Powered by Google App Engine
This is Rietveld 408576698