src/ia32/codegen-ia32.cc - Issue 660172: Changed GeneratePow ensure xmm1 is loaded with y before making the test for N...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/codegen-ia32.cc

Issue 660172: Changed GeneratePow ensure xmm1 is loaded with y before making the test for N... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/codegen-ia32.cc

===================================================================

--- src/ia32/codegen-ia32.cc (revision 3964)

+++ src/ia32/codegen-ia32.cc (working copy)

@@ -5368,13 +5368,12 @@

__ cmp(FieldOperand(y.reg(), HeapObject::kMapOffset),

Factory::heap_number_map());

__ j(not_equal, &go_runtime);

+ // Y must be a double.

+ __ movdbl(xmm1, FieldOperand(y.reg(), HeapNumber::kValueOffset));

// Test if y is nan.

__ ucomisd(xmm1, xmm1);

__ j(parity_even, &go_runtime);

- // Y must be a double.

- __ movdbl(xmm1, FieldOperand(y.reg(), HeapNumber::kValueOffset));

Label x_not_smi;

Label handle_special_cases;

__ test(x.reg(), Immediate(kSmiTagMask));

« no previous file with comments | « no previous file | no next file » | no next file with comments »