Issue 660118: Merge the LINUX_TC_MALLOC #define with the existing TC_MALLOC #define....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660118: Merge the LINUX_TC_MALLOC #define with the existing TC_MALLOC #define.... (Closed)

Created:
10 years, 10 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Merge the LINUX_TC_MALLOC #define with the existing TC_MALLOC #define. BUG=36687 TEST=about:tcmalloc, etc, works when tcmalloc is enabled on Linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40080

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -30 lines)			Patch
M	base/base.gypi	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	base/leak_annotations.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	base/process_util_linux.cc	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	base/process_util_unittest.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	build/build_config.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/app/chrome_exe_main_gtk.cc	View	1	3 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/browser/memory_purger.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/renderer/render_thread.cc	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/extensions/v8/heap_profiler_extension.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

With this CL, when we enable tcmalloc on Linux, we'll get all the extras like ...

10 years, 10 months ago (2010-02-25 21:46:42 UTC) #1

LGTM!  Thanks!

Expand Messages | Collapse Messages