add chromeos_builder target.

add chromeos_builder target. 

ideally everything we want to pull from chrome should be dependencies of this target. build-bots will be changed to build this from chromeos

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40089

[jiesun, 2010-02-25 20:57:24]

first step to add chromeos_builder target, which cover all the target we want to
archive build and made available to chrome os environment.

next step is to 
1. add build-bot target and ebuild target.
2. add file to archive list.
3. modify build_autotest.sh to consume those binaries.

[Alpha Left Google, 2010-02-25 21:00:42]

http://codereview.chromium.org/660110/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/660110/diff/1/2#newcode260
build/all.gyp:260: # should we put candidate_window/session here ?
prefix these two lines with TODO(jiesun):

[bradn, 2010-02-25 21:08:06]

http://codereview.chromium.org/660110/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/660110/diff/1/2#newcode258
build/all.gyp:258: '../media/media.gyp:omx_test',
You will want chrome here. Along with anything else you want built. I'd suggest
duplicating everything in the chrome release builder to start, and pare it back
later.

[bradn, 2010-02-25 21:50:35]

LGTM after changes you showed me in person.

[fbarchard, 2010-02-25 22:07:03]

thanks jie!

http://codereview.chromium.org/660110/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/660110/diff/1/2#newcode258
build/all.gyp:258: '../media/media.gyp:omx_test',
potential concern - may need to check branding. openmax is not intended to work
in chromiumos.  I know my end, ffmpeg, does not provide the bsfs.  But I checked
with andrew, and he thinks it will build... just not run.

http://codereview.chromium.org/660110/diff/1/2#newcode259
build/all.gyp:259: '../media/media.gyp:ffmpeg_tests',
I'd prefer ffmpeg_tests work on all platforms... its useful and easier to test
that way.

http://codereview.chromium.org/660110/diff/1/2#newcode260
build/all.gyp:260: # should we put candidate_window/session here ?
I dont understand the comments either. please clarify.  perhaps show what you
think should be put there

[jiesun, 2010-02-25 23:52:03]

done.

http://codereview.chromium.org/660110/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/660110/diff/1/2#newcode258
build/all.gyp:258: '../media/media.gyp:omx_test',
On 2010/02/25 21:08:07, bradn wrote:
> You will want chrome here. Along with anything else you want built. I'd
suggest
> duplicating everything in the chrome release builder to start, and pare it
back
> later.
> 

Done.

http://codereview.chromium.org/660110/diff/1/2#newcode259
build/all.gyp:259: '../media/media.gyp:ffmpeg_tests',
On 2010/02/25 22:07:03, fbarchard wrote:
> I'd prefer ffmpeg_tests work on all platforms... its useful and easier to test
> that way.
> 
this is probably only for chrome os , we will pull ffmpeg_tests to autotest
directory. that's why we mess with archived build.

http://codereview.chromium.org/660110/diff/1/2#newcode260
build/all.gyp:260: # should we put candidate_window/session here ?
On 2010/02/25 22:07:03, fbarchard wrote:
> I dont understand the comments either. please clarify.  perhaps show what you
> think should be put there
those are other dependency and archived files which are already there. but they
use different method to get into the build-bots

http://codereview.chromium.org/660110/diff/1/2#newcode260
build/all.gyp:260: # should we put candidate_window/session here ?
On 2010/02/25 21:00:42, Alpha wrote:
> prefix these two lines with TODO(jiesun):

Done.