Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 66011: Workaround for http://crbug.com/9746:... (Closed)

Created:
11 years, 8 months ago by iposva
Modified:
9 years, 4 months ago
Reviewers:
Mike Belshe
CC:
v8-dev
Visibility:
Public.

Description

Workaround for http://crbug.com/9746: - Added special cutouts if a Vector has NULL data, which will now happen if an external string's resource has been deleted. - Added an verification phase before old gen GC to verify that all real entries in the SymbolTable are valid symbols. - Added test that verifies the correct behaviour of the workaround. Committed: http://code.google.com/p/v8/source/detail?r=1689

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -3 lines) Patch
M src/mark-compact.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M src/objects.cc View 1 6 chunks +40 lines, -3 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
iposva
11 years, 8 months ago (2009-04-09 22:41:17 UTC) #1
Mike Belshe
lgtm http://codereview.chromium.org/66011/diff/1/2 File src/objects.cc (right): http://codereview.chromium.org/66011/diff/1/2#newcode4149 Line 4149: Vector<const uc16> vecb = b->ToUC16Vector(); Is 'vecb' ...
11 years, 8 months ago (2009-04-09 22:55:56 UTC) #2
iposva
11 years, 8 months ago (2009-04-09 23:02:09 UTC) #3
Not sure if this helps readability, but at least it is "consistent" now.

-Ivan

http://codereview.chromium.org/66011/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/66011/diff/1/2#newcode4149
Line 4149: Vector<const uc16> vecb = b->ToUC16Vector();
On 2009/04/09 22:55:56, Mike Belshe wrote:
> Is 'vecb' a good name?  (not sure what it is?)

Renamed to vb to match the existing convention naming the VectorIterator for the
string b: ib.

Powered by Google App Engine
This is Rietveld 408576698