Optimize 3 Number2Integer functions in runtime.cc: remove the check that was ...

Optimize three Number2Integer functions in runtime.cc: remove the check that was already done in JavaScript, add simpler code in case we are getting a SMI result.

[Mads Ager (chromium), 2010-02-25 15:11:03]

LGTM

http://codereview.chromium.org/660084/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/660084/diff/1/2#newcode4157
src/runtime.cc:4157: // We do not include 0 so that we didn't have to treat +0 /
-0 cases.
didn't -> don't

http://codereview.chromium.org/660084/diff/1/2#newcode4158
src/runtime.cc:4158: if (number > 0 && number <= Smi::kMaxValue)
Please use braces around both the if and the else body.

if (...) {
  ...
} else {
  ...
}

http://codereview.chromium.org/660084/diff/1/2#newcode4169
src/runtime.cc:4169: Object* obj = args[0];
Just use args[0] in the CONVERT_NUMBER_CHECKED below?

http://codereview.chromium.org/660084/diff/1/2#newcode4180
src/runtime.cc:4180: if (number > 0 && number <= Smi::kMaxValue)
Please use braces here as well.  Repeat the comment about not handling 0 because
of the -0/+0 complications?

[Oleg Eterevsky, 2010-02-25 15:30:43]

http://codereview.chromium.org/660084/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/660084/diff/1/2#newcode4157
src/runtime.cc:4157: // We do not include 0 so that we didn't have to treat +0 /
-0 cases.
On 2010/02/25 15:11:03, Mads Ager wrote:
> didn't -> don't

Done.

http://codereview.chromium.org/660084/diff/1/2#newcode4158
src/runtime.cc:4158: if (number > 0 && number <= Smi::kMaxValue)
On 2010/02/25 15:11:03, Mads Ager wrote:
> Please use braces around both the if and the else body.
> 
> if (...) {
>   ...
> } else {
>   ...
> }

Done.

http://codereview.chromium.org/660084/diff/1/2#newcode4169
src/runtime.cc:4169: Object* obj = args[0];
On 2010/02/25 15:11:03, Mads Ager wrote:
> Just use args[0] in the CONVERT_NUMBER_CHECKED below?

Done.

http://codereview.chromium.org/660084/diff/1/2#newcode4180
src/runtime.cc:4180: if (number > 0 && number <= Smi::kMaxValue)
On 2010/02/25 15:11:03, Mads Ager wrote:
> Please use braces here as well.  Repeat the comment about not handling 0
because
> of the -0/+0 complications?

Done.

[William Hesse, 2010-02-25 18:09:44]

This change fails to compile on MacOS in debug mode, with the error:

g++ -o obj/debug/runtime.o -c -Wall -Werror -W -Wno-unused-parameter
-Wnon-virtual-dtor -pedantic -m32 -g -O0 -ansi -mmacosx-version-min=10.4
-fno-rtti -fno-exceptions -fvisibility=hidden -Wall -Werror -W
-Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m32 -g -O0 -ansi
-mmacosx-version-min=10.4 -DV8_TARGET_ARCH_IA32 -DENABLE_DISASSEMBLER -DDEBUG
-DENABLE_DEBUGGER_SUPPORT -DV8_NATIVE_REGEXP -DV8_ENABLE_CHECKS
-DENABLE_LOGGING_AND_PROFILING -Isrc src/runtime.cc
cc1plus: warnings being treated as errors
src/runtime.cc: In function 'v8::internal::Object*
v8::internal::Runtime_NumberToJSInt32(v8::internal::Arguments)':
src/runtime.cc:4187: warning: control reaches end of non-void function
src/runtime.cc: In function 'v8::internal::Object*
v8::internal::Runtime_NumberToInteger(v8::internal::Arguments)':
src/runtime.cc:4163: warning: control reaches end of non-void function
scons: *** [obj/debug/runtime.o] Error 1
scons: done building targets (errors occurred during build).
program finished with exit code 2
elapsedTime=5.347686