src/x64/regexp-macro-assembler-x64.cc - Issue 660078: Adding 'static const' for arg numbers used with CallCFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/regexp-macro-assembler-x64.cc

Issue 660078: Adding 'static const' for arg numbers used with CallCFunction. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/regexp-macro-assembler-x64.cc

===================================================================

--- src/x64/regexp-macro-assembler-x64.cc (revision 3946)

+++ src/x64/regexp-macro-assembler-x64.cc (working copy)

@@ -335,7 +335,7 @@

#endif

__ push(backtrack_stackpointer());

- int num_arguments = 3;

+ static const int num_arguments = 3;

__ PrepareCallCFunction(num_arguments);

// Put arguments into parameter registers. Parameters are

@@ -849,7 +849,7 @@

#endif

// Call GrowStack(backtrack_stackpointer())

- int num_arguments = 2;

+ static const int num_arguments = 2;

__ PrepareCallCFunction(num_arguments);

#ifdef _WIN64

// Microsoft passes parameters in rcx, rdx.

@@ -1029,7 +1029,7 @@

void RegExpMacroAssemblerX64::CallCheckStackGuardState() {

// This function call preserves no register values. Caller should

// store anything volatile in a C call or overwritten by this function.

- int num_arguments = 3;

+ static const int num_arguments = 3;

__ PrepareCallCFunction(num_arguments);

#ifdef _WIN64

// Second argument: Code* of self. (Do this before overwriting r8).

« no previous file with comments | « src/x64/codegen-x64.cc ('k') | no next file » | no next file with comments »