Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: skia/skia.gyp

Issue 660067: Separate neon flags from armv7, because some platforms have armv7a but no neon. (Closed)
Patch Set: Fix configure flags Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/ffmpeg/ffmpeg.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/skia.gyp
diff --git a/skia/skia.gyp b/skia/skia.gyp
index d85f2a1b2fe2af2b2fa5bbfc29f79c5d9054de10..27abe1c50654ddba327fa4b888f35633c9a89a25 100644
--- a/skia/skia.gyp
+++ b/skia/skia.gyp
@@ -579,10 +579,14 @@
}],
[ 'armv7 == 1', {
'defines': [
- '__ARM_HAVE_NEON',
'__ARM_ARCH__=7',
],
}],
+ [ 'armv7 == 1 and arm_neon == 1', {
+ 'defines': [
+ '__ARM_HAVE_NEON',
+ ],
+ }],
[ 'target_arch == "arm"', {
'sources!': [
'../third_party/skia/src/opts/opts_check_SSE2.cpp'
@@ -704,12 +708,16 @@
},
{ # arm
'conditions': [
- ['armv7 == 1', {
+ [ 'armv7 == 1', {
'defines': [
- '__ARM_HAVE_NEON',
'__ARM_ARCH__=7',
],
- }]
+ }],
+ [ 'armv7 == 1 and arm_neon == 1', {
+ 'defines': [
+ '__ARM_HAVE_NEON',
+ ],
+ }],
],
# The assembly uses the frame pointer register (r7 in Thumb/r11 in
# ARM), the compiler doesn't like that.
« no previous file with comments | « build/common.gypi ('k') | third_party/ffmpeg/ffmpeg.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698