Separate neon flags from armv7, because some platforms have armv7a but no neon.

Separate neon flags from armv7, because some platforms have armv7a but no neon.

For ffmpeg, I copied the "arm" configs (which include neon) into "arm-neon" configs, and changed HAVE_NEON=1 to 0 in the existing ones. Also, I removed the explicit cflags in ffmpeg.gyp since they are already set in common.gypi

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40163

[piman, 2010-02-25 20:43:48]

Frank and/or Alpha, please review the ffmpeg changes
Stephen, please review the skia change.

[Alpha Left Google, 2010-02-25 20:58:42]

ffmpeg side: LGTM with changes in #define

[Stephen White, 2010-02-25 21:05:58]

LGTM.

[fbarchard, 2010-02-26 06:16:47]

LGTM with nit

Like the comment says, config.h headers are generated.
Short term, you can get away with diffs, but should try to keep the config
command line up to date, for when we do regenerate
I actually wrote a script, since there were 16 configs, 12 of which are linux
based.  But all I did was take the FFMPEG_CONFIGURATION from each config.h ...
at least as a starting point.

The approach you're taking is good for netbooks, but I was thinking a cpuid
would be better for general purpose linux?

http://codereview.chromium.org/660067/diff/24/29
File third_party/ffmpeg/source/config/Chrome/linux/arm/config.h (right):

http://codereview.chromium.org/660067/diff/24/29#newcode4
third_party/ffmpeg/source/config/Chrome/linux/arm/config.h:4: #define
FFMPEG_CONFIGURATION "--disable-ffmpeg --disable-ffplay --disable-ffserver
--enable-shared --disable-static --disable-debug --disable-network
--disable-encoders --disable-decoders --disable-hwaccels --disable-muxers
--disable-demuxers --disable-parsers --disable-bsfs --disable-protocols
--disable-devices --disable-filters --disable-gpl --enable-decoder=theora
--enable-decoder=vorbis --enable-demuxer=ogg --enable-decoder=aac
--enable-decoder=h264 --enable-decoder=mp3 --enable-demuxer=mp3
--enable-demuxer=mov --enable-parser=mpegaudio --enable-pthreads
--enable-cross-compile --arch=arm --enable-armv6 --enable-armv6t2
--enable-armvfp --enable-neon
--cross-prefix=/usr/local/google/cross-tools/arm-2009q3/bin/arm-none-linux-gnueabi-
--extra-cflags='-march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp'
--prefix=./chrome-ffmpeg"
This should have
--disable-neon

http://codereview.chromium.org/660067/diff/24/29#newcode38
third_party/ffmpeg/source/config/Chrome/linux/arm/config.h:38: #define
HAVE_ARMV6T2 1
Can you confirm these other ARM instruction sets all make sense?

[piman, 2010-02-26 19:30:18]

http://codereview.chromium.org/660067/diff/24/29
File third_party/ffmpeg/source/config/Chrome/linux/arm/config.h (right):

http://codereview.chromium.org/660067/diff/24/29#newcode4
third_party/ffmpeg/source/config/Chrome/linux/arm/config.h:4: #define
FFMPEG_CONFIGURATION "--disable-ffmpeg --disable-ffplay --disable-ffserver
--enable-shared --disable-static --disable-debug --disable-network
--disable-encoders --disable-decoders --disable-hwaccels --disable-muxers
--disable-demuxers --disable-parsers --disable-bsfs --disable-protocols
--disable-devices --disable-filters --disable-gpl --enable-decoder=theora
--enable-decoder=vorbis --enable-demuxer=ogg --enable-decoder=aac
--enable-decoder=h264 --enable-decoder=mp3 --enable-demuxer=mp3
--enable-demuxer=mov --enable-parser=mpegaudio --enable-pthreads
--enable-cross-compile --arch=arm --enable-armv6 --enable-armv6t2
--enable-armvfp --enable-neon
--cross-prefix=/usr/local/google/cross-tools/arm-2009q3/bin/arm-none-linux-gnueabi-
--extra-cflags='-march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp'
--prefix=./chrome-ffmpeg"
On 2010/02/26 06:16:47, fbarchard wrote:
> This should have
> --disable-neon 
> 

Done, also set -mfpu=vfp

http://codereview.chromium.org/660067/diff/24/29#newcode38
third_party/ffmpeg/source/config/Chrome/linux/arm/config.h:38: #define
HAVE_ARMV6T2 1
On 2010/02/26 06:16:47, fbarchard wrote:
> Can you confirm these other ARM instruction sets all make sense?
> 

As far as I know, ARMV7 includes the previous archs, so this is good. I haven't
verified if the code is used or if the VFP code overrides it anyway.

[fbarchard, 2010-02-26 22:48:24]

LGTM

I will have to update documentation / configure scripts to match.
If I check in first, my arm config will be like yours, with neon off.