Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 660038: Fix issue 32106 (Closed)

Created:
10 years, 10 months ago by xiyuan
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Fix issue 32106 Issue 32106 happens when user creates a browser window without creating desktop shortcut. In this case, Windows does not have sufficient relaunching info to support pinning the browser window. The fix is to create a shortcut in "User Pinned" folder which Win7 watches and would get relaunch info from it. Also fix a minor bug in win_util::SetAppIdForWindow that would make the function only work for Win7 but not above. BUG=32106 TEST=Verify fix for 32106. See comemnts #1 and #5 for repro steps. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -8 lines) Patch
M app/win_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_data_manager.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/user_data_manager.cc View 3 chunks +19 lines, -5 lines 0 comments Download
M chrome/browser/views/new_profile_dialog.cc View 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
xiyuan
sky, could you review this CL? Thanks.
10 years, 10 months ago (2010-02-24 23:23:57 UTC) #1
sky
10 years, 10 months ago (2010-02-24 23:33:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698