Restore -Wall to Linux build and set up for -Werror.

Restore -Wall to Linux build and set up for -Werror.
* Add -Wall to build/common.gypi (and -Werror, commented out for now).
* Have build/external_code.gypi remove -Wall (and -Werror).
* Remove chromium_code definition from build/all.gyp.
* Remove chromium_code definitions from third_party/ *.gyp files.
* Remove scons-specific -Werror removal in webkit.gyp.
* Remove unused variables from:
  base/clipboard_linux.cc
  chrome/browser/gtk/download_shelf_gtk.cc
  chrome/browser/gtk/bookmark_bar_gtk.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13478

[Mark Mentovai, 2009-04-09 22:03:07]

LGTM on the GYP fixes.  And thanks for tackling some of these warnings.

http://codereview.chromium.org/66001/diff/1/10
File chrome/browser/gtk/download_shelf_gtk.cc (right):

http://codereview.chromium.org/66001/diff/1/10#newcode139
Line 139: // can be clicked. I tried to fix this with a vbox (akin to
|centering_vbox|
This comment still refers to centering_vbox, it probably needs to come out?

http://codereview.chromium.org/66001/diff/1/4
File third_party/ffmpeg/ffmpeg.gyp (left):

http://codereview.chromium.org/66001/diff/1/4#oldcode7
Line 7: 'chromium_code': 1,
Andrew said something about something not working when this was not
chromium_code.  It sounded suspicious to me, but to be safe, just make sure this
passes the tryservers.

[sgk, 2009-04-09 22:41:41]

http://codereview.chromium.org/66001/diff/1/10
File chrome/browser/gtk/download_shelf_gtk.cc (right):

http://codereview.chromium.org/66001/diff/1/10#newcode139
Line 139: // can be clicked. I tried to fix this with a vbox (akin to
|centering_vbox|
On 2009/04/09 22:03:07, Mark Mentovai wrote:
> This comment still refers to centering_vbox, it probably needs to come out?

Done.

(I removed the parenthetical re: the removed variable, but left the gist of the
comment about clickable pixels.)

http://codereview.chromium.org/66001/diff/1/4
File third_party/ffmpeg/ffmpeg.gyp (left):

http://codereview.chromium.org/66001/diff/1/4#oldcode7
Line 7: 'chromium_code': 1,
On 2009/04/09 22:03:07, Mark Mentovai wrote:
> Andrew said something about something not working when this was not
> chromium_code.  It sounded suspicious to me, but to be safe, just make sure
this
> passes the tryservers.

I got passes on all three, so going ahead with commit and will monitor.