Chromium Code Reviews| Index: kernel_collector.h |
| diff --git a/kernel_collector.h b/kernel_collector.h |
| index 708fd1b9ee7641c3b0de62f2a8c9dd0f0e996758..e1fc67611d5da48f1b5399e1869abeae5fe3283d 100644 |
| --- a/kernel_collector.h |
| +++ b/kernel_collector.h |
| @@ -18,6 +18,15 @@ class FilePath; |
| // Kernel crash collector. |
| class KernelCollector : public CrashCollector { |
| public: |
| + // Enumeration to specify architecture type. |
| + enum ArchKind { |
| + archArm, // ARM variant. |
|
kmixter1
2011/04/05 00:09:26
nit: the comments seem superfluous here
sjg
2011/04/05 17:45:04
removed
|
| + archX86, // X86 variant. |
| + archUnknown, // We don't know. |
|
kmixter1
2011/04/05 00:09:26
nit: In this code base unknown is usually the zero
sjg
2011/04/05 17:45:04
done
|
| + |
| + archCount // Number of architectures. |
| + }; |
| + |
| KernelCollector(); |
| virtual ~KernelCollector(); |
| @@ -41,6 +50,10 @@ class KernelCollector : public CrashCollector { |
| std::string *kernel_signature, |
| bool print_diagnostics); |
| + // Set the architecture of the crash dumps we are looking at. |
| + void SetArch(enum ArchKind arch); |
| + enum ArchKind GetArch() { return arch_; } |
| + |
| private: |
| friend class KernelCollectorTest; |
| FRIEND_TEST(KernelCollectorTest, ClearPreservedDump); |
| @@ -62,9 +75,13 @@ class KernelCollector : public CrashCollector { |
| bool print_diagnostics, |
| std::string *panic_message); |
| + // Returns the architecture kind for which we are built - enum ArchKind |
|
kmixter1
2011/04/05 00:09:26
add period.
sjg
2011/04/05 17:45:04
done
|
| + enum ArchKind GetCompilerArch(void); |
| + |
| bool is_enabled_; |
| FilePath preserved_dump_path_; |
| static const char kClearingSequence[]; |
| + enum ArchKind arch_; // The architecture we are working with |
|
kmixter1
2011/04/05 00:09:26
period. Maybe say the architecture of kernel dump
sjg
2011/04/05 17:45:04
done
|
| }; |
| #endif // _CRASH_REPORTER_KERNEL_COLLECTOR_H_ |