Add ARM support

kernel_collector_test.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <unistd.h>
 
 #include "base/file_util.h"
 #include "base/string_util.h"
 #include "chromeos/syslog_logging.h"
 #include "chromeos/test_helpers.h"
@@ skipping 32 matching lines @@
   }
  protected:
   void WriteStringToFile(const FilePath &file_path,
                          const char *data) {
     ASSERT_EQ(strlen(data),
               file_util::WriteFile(file_path, data, strlen(data)));
   }
 
   void SetUpSuccessfulCollect();
   void CheckPreservedDumpClear();
+  void ComputeKernelStackSignatureCommon();
 
   KernelCollector collector_;
   FilePath test_kcrash_;
 };
 
+TEST_F(KernelCollectorTest, ComputeKernelStackSignatureBase) {
+  // Make sure the normal build architecture is detected
+  EXPECT_TRUE(collector_.GetArch() != KernelCollector::archUnknown);
+}
+
 TEST_F(KernelCollectorTest, LoadPreservedDump) {
   ASSERT_FALSE(file_util::PathExists(test_kcrash_));
   std::string dump;
   ASSERT_FALSE(collector_.LoadPreservedDump(&dump));
   WriteStringToFile(test_kcrash_, "");
   ASSERT_TRUE(collector_.LoadPreservedDump(&dump));
   ASSERT_EQ("", dump);
   WriteStringToFile(test_kcrash_, "something");
   ASSERT_TRUE(collector_.LoadPreservedDump(&dump));
   ASSERT_EQ("something", dump);
@@ skipping 87 matching lines @@
   filename = filename.substr(0, end_pos);
   ASSERT_EQ(0, filename.find(kTestCrashDirectory));
   ASSERT_TRUE(file_util::PathExists(FilePath(filename)));
   std::string contents;
   ASSERT_TRUE(file_util::ReadFileToString(FilePath(filename), &contents));
   ASSERT_EQ("something", contents);
 
   CheckPreservedDumpClear();
 }
 
-TEST_F(KernelCollectorTest, ComputeKernelStackSignature) {
+// Perform tests which are common across architectures
+void KernelCollectorTest::ComputeKernelStackSignatureCommon() {
+  std::string signature;
+
+  const char kStackButNoPC[] =
+      "<4>[ 6066.829029]  [<790340af>] __do_softirq+0xa6/0x143\n";
+  EXPECT_TRUE(
+      collector_.ComputeKernelStackSignature(kStackButNoPC, &signature, false));
+  EXPECT_EQ("kernel--83615F0A", signature);
+
+  const char kMissingEverything[] =
+      "<4>[ 6066.829029]  [<790340af>] ? __do_softirq+0xa6/0x143\n";
+  EXPECT_FALSE(
+      collector_.ComputeKernelStackSignature(kMissingEverything,
+                                             &signature,
+                                             false));
+
+  // Long message.
+  const char kTruncatedMessage[] =
+      "<0>[   87.485611] Kernel panic - not syncing: 01234567890123456789"
+          "01234567890123456789X\n";
+  EXPECT_TRUE(
+      collector_.ComputeKernelStackSignature(kTruncatedMessage,
+                                             &signature,
+                                             false));
+  EXPECT_EQ("kernel-0123456789012345678901234567890123456789-00000000",
+            signature);
+}
+
+TEST_F(KernelCollectorTest, ComputeKernelStackSignatureARM) {
+  const char kBugToPanic[] =
+      "<5>[  123.412524] Modules linked in:\n"
+      "<5>[  123.412534] CPU: 0    Tainted: G        W    "
+          "(2.6.37-01030-g51cee64 #153)\n"
+      "<5>[  123.412552] PC is at write_breakme+0xd0/0x1b4\n"
+      "<5>[  123.412560] LR is at write_breakme+0xc8/0x1b4\n"
+      "<5>[  123.412569] pc : [<c0058220>]    lr : [<c005821c>]    "
+          "psr: 60000013\n"
+      "<5>[  123.412574] sp : f4e0ded8  ip : c04d104c  fp : 000e45e0\n"
+      "<5>[  123.412581] r10: 400ff000  r9 : f4e0c000  r8 : 00000004\n"
+      "<5>[  123.412589] r7 : f4e0df80  r6 : f4820c80  r5 : 00000004  "
+          "r4 : f4e0dee8\n"
+      "<5>[  123.412598] r3 : 00000000  r2 : f4e0decc  r1 : c05f88a9  "
+          "r0 : 00000039\n"
+      "<5>[  123.412608] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA "
+          "ARM  Segment user\n"
+      "<5>[  123.412617] Control: 10c53c7d  Table: 34dcc04a  DAC: 00000015\n"
+      "<0>[  123.412626] Process bash (pid: 1014, stack limit = 0xf4e0c2f8)\n"
+      "<0>[  123.412634] Stack: (0xf4e0ded8 to 0xf4e0e000)\n"
+      "<0>[  123.412641] dec0:                                              "
+          "         f4e0dee8 c0183678\n"
+      "<0>[  123.412654] dee0: 00000000 00000000 00677562 0000081f c06a6a78 "
+          "400ff000 f4e0dfb0 00000000\n"
+      "<0>[  123.412666] df00: bec7ab44 000b1719 bec7ab0c c004f498 bec7a314 "
+          "c024acc8 00000001 c018359c\n"
+      "<0>[  123.412679] df20: f4e0df34 c04d10fc f5803c80 271beb39 000e45e0 "
+          "f5803c80 c018359c c017bfe0\n"
+      "<0>[  123.412691] df40: 00000004 f4820c80 400ff000 f4e0df80 00000004 "
+          "f4e0c000 00000000 c01383e4\n"
+      "<0>[  123.412703] df60: f4820c80 400ff000 f4820c80 400ff000 00000000 "
+          "00000000 00000004 c0138578\n"
+      "<0>[  123.412715] df80: 00000000 00000000 00000004 00000000 00000004 "
+          "402f95d0 00000004 00000004\n"
+      "<0>[  123.412727] dfa0: c0054984 c00547c0 00000004 402f95d0 00000001 "
+          "400ff000 00000004 00000000\n"
+      "<0>[  123.412739] dfc0: 00000004 402f95d0 00000004 00000004 400ff000 "
+          "000c194c bec7ab58 000e45e0\n"
+      "<0>[  123.412751] dfe0: 00000000 bec7aad8 40232520 40284e9c 60000010 "
+          "00000001 00000000 00000000\n"
+      "<5>[   39.496577] Backtrace:\n"
+      "<5>[  123.412782] [<c0058220>] (__bug+0x20/0x2c) from [<c0183678>] "
+          "(write_breakme+0xdc/0x1bc)\n"
+      "<5>[  123.412798] [<c0183678>] (write_breakme+0xdc/0x1bc) from "
+          "[<c017bfe0>] (proc_reg_write+0x88/0x9c)\n";
+  std::string signature;
+
+  collector_.SetArch(KernelCollector::archArm);
+  EXPECT_TRUE(
+      collector_.ComputeKernelStackSignature(kBugToPanic, &signature, false));
+  EXPECT_EQ("kernel-write_breakme-97D3E92F", signature);
+
+  const char kPCButNoStack[] =

[kmixter1, 2011/04/05 23:29:11]

So kPCButNoStack/kPCLineTooOld/kExamplePanicOnly are still duplicated between
x86 and arm. CAn't they be refactored out into the ocmmon function too?

[sjg, 2011/04/06 02:02:57]

They look different to me?

+      "<5>[  123.412552] PC is at write_breakme+0xd0/0x1b4";
+  EXPECT_TRUE(
+      collector_.ComputeKernelStackSignature(kPCButNoStack, &signature, false));
+  EXPECT_EQ("kernel-write_breakme-00000000", signature);
+
+  const char kPCLineTooOld[] =
+      "<4>[  123.402137]  [<790970c6>] ignored_function+0x67f/0x96d\n"
+      "<5>[  123.412552] PC is at write_breakme+0xd0/0x1b4\n"
+      "<4>[  180.502026] Backtrace:\n"
+      "<0>[  180.502026] Kernel panic - not syncing: Fatal exception\n"
+      "<4>[  180.502806]  [<79379aba>] printk+0x14/0x1a\n";
+
+  EXPECT_TRUE(
+      collector_.ComputeKernelStackSignature(kPCLineTooOld, &signature, false));
+  EXPECT_EQ("kernel-Fatal exception-ED4C84FE", signature);
+
+  // Panic without EIP line.

[kmixter1, 2011/04/05 23:29:11]

The EIP typo will go away if you combine these. :)

[sjg, 2011/04/06 02:02:57]

Ooops, saw that a while back and forgot to fix...

+  const char kExamplePanicOnly[] =
+      "<0>[   39.543808] Kernel panic - not syncing: Testing panic\n"
+      "<5>[   39.543815] Backtrace:\n"
+      "<5>[   39.543840] [<c005ca30>] (unwind_backtrace+0x0/0xf8) from "
+          "[<c04caf38>] (panic+0x68/0x190)\n"
+      "<5>[   39.543856] [<c04caf38>] (panic+0x68/0x190) from [<c005a93c>] "
+          "(die+0x2bc/0x330)\n"
+      "<5>[   39.543871] [<c005a93c>] (die+0x2bc/0x330) from [<c00511e0>] "
+          "(do_undefinstr+0x120/0x138)\n"
+      "<5>[   39.543892] [<c00511e0>] (do_undefinstr+0x120/0x138) from "
+          "[<c04ced84>] (__und_svc+0x44/0x60)\n";
+  EXPECT_TRUE(
+      collector_.ComputeKernelStackSignature(kExamplePanicOnly,
+                                             &signature,
+                                             false));
+  EXPECT_EQ("kernel-Testing panic-735A6297", signature);
+  ComputeKernelStackSignatureCommon();
+}
+
+
+TEST_F(KernelCollectorTest, ComputeKernelStackSignatureX86) {
   const char kBugToPanic[] =
       "<4>[ 6066.829029]  [<79039d16>] ? run_timer_softirq+0x165/0x1e6\n"
       "<4>[ 6066.829029]  [<790340af>] ignore_old_stack+0xa6/0x143\n"
       "<0>[ 6066.829029] EIP: [<b82d7c15>] ieee80211_stop_tx_ba_session+"
           "0xa3/0xb5 [mac80211] SS:ESP 0068:7951febc\n"
       "<0>[ 6066.829029] CR2: 00000000323038a7\n"
       "<4>[ 6066.845422] ---[ end trace 12b058bb46c43500 ]---\n"
       "<0>[ 6066.845747] Kernel panic - not syncing: Fatal exception "
           "in interrupt\n"
       "<0>[ 6066.846902] Call Trace:\n"
       "<4>[ 6066.846902]  [<7937a07b>] ? printk+0x14/0x19\n"
       "<4>[ 6066.949779]  [<79379fc1>] panic+0x3e/0xe4\n"
       "<4>[ 6066.949971]  [<7937c5c5>] oops_end+0x73/0x81\n"
       "<4>[ 6066.950208]  [<7901b260>] no_context+0x10d/0x117\n";
   std::string signature;
+
+  collector_.SetArch(KernelCollector::archX86);
   EXPECT_TRUE(
       collector_.ComputeKernelStackSignature(kBugToPanic, &signature, false));
   EXPECT_EQ("kernel-ieee80211_stop_tx_ba_session-DE253569", signature);
 
   const char kPCButNoStack[] =
       "<0>[ 6066.829029] EIP: [<b82d7c15>] ieee80211_stop_tx_ba_session+";
   EXPECT_TRUE(
       collector_.ComputeKernelStackSignature(kPCButNoStack, &signature, false));
   EXPECT_EQ("kernel-ieee80211_stop_tx_ba_session-00000000", signature);
 
-  const char kStackButNoPC[] =
-      "<4>[ 6066.829029]  [<790340af>] __do_softirq+0xa6/0x143\n";
-  EXPECT_TRUE(
-      collector_.ComputeKernelStackSignature(kStackButNoPC, &signature, false));
-  EXPECT_EQ("kernel--83615F0A", signature);
-
-  const char kMissingEverything[] =
-      "<4>[ 6066.829029]  [<790340af>] ? __do_softirq+0xa6/0x143\n";
-  EXPECT_FALSE(
-      collector_.ComputeKernelStackSignature(kMissingEverything,
-                                             &signature,
-                                             false));
-
   const char kBreakmeBug[] =
       "<4>[  180.492137]  [<790970c6>] ? handle_mm_fault+0x67f/0x96d\n"
       "<4>[  180.492137]  [<790dcdfe>] ? proc_reg_write+0x5f/0x73\n"
       "<4>[  180.492137]  [<790e2224>] ? write_breakme+0x0/0x108\n"
       "<4>[  180.492137]  [<790dcd9f>] ? proc_reg_write+0x0/0x73\n"
       "<4>[  180.492137]  [<790ac0aa>] vfs_write+0x85/0xe4\n"
       "<0>[  180.492137] Code: c6 44 05 b2 00 89 d8 e8 0c ef 09 00 85 c0 75 "
       "0b c7 00 00 00 00 00 e9 8e 00 00 00 ba e6 75 4b 79 89 d8 e8 f1 ee 09 "
       "00 85 c0 75 04 <0f> 0b eb fe ba 58 47 49 79 89 d8 e8 dd ee 09 00 85 "
       "c0 75 0a 68\n"
@@ skipping 34 matching lines @@
           "C 2.6.32.23+drm33.10 #1\n"
       "<4>[   87.485639] Call Trace:\n"
       "<4>[   87.485660]  [<8133f71d>] ? printk+0x14/0x17\n"
       "<4>[   87.485674]  [<8133f663>] panic+0x3e/0xe4\n"
       "<4>[   87.485689]  [<810d062e>] write_breakme+0xaa/0x124\n";
   EXPECT_TRUE(
       collector_.ComputeKernelStackSignature(kExamplePanicOnly,
                                              &signature,
                                              false));
   EXPECT_EQ("kernel-Testing panic-E0FC3552", signature);
-
-  // Long message.
-  const char kTruncatedMessage[] =
-      "<0>[   87.485611] Kernel panic - not syncing: 01234567890123456789"
-          "01234567890123456789X\n";
-  EXPECT_TRUE(
-      collector_.ComputeKernelStackSignature(kTruncatedMessage,
-                                             &signature,
-                                             false));
-  EXPECT_EQ("kernel-0123456789012345678901234567890123456789-00000000",
-            signature);
-
+  ComputeKernelStackSignatureCommon();
 }
 
 int main(int argc, char **argv) {
   SetUpTests(&argc, argv, false);
   return RUN_ALL_TESTS();
 }