Modify ThreadChecker and NonThreadSafe so that their functionality is

Modify ThreadChecker and NonThreadSafe so that their 
functionality is available in release builds if explicitly 
requested by using their Impl types. The default usage remains 
that they do nothing in release mode.

Also, update unit tests to run in release mode, verifying that the release versions of NonThreadSafe and ThreadChecker do nothing in release builds.

BUG=none
TEST=base unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76833

[Jói, 2011-03-01 21:59:17]

As we had discussed briefly; what do you think? There are other ways to do it
that would probably allow us to bring back forward declarations (I don't know if
that's really worth it, they were only used in two places) and could switch to a
pimpl approach to reduce header bloat, but not sure it's worth it.

[brettw, 2011-03-03 17:39:43]

http://codereview.chromium.org/6599004/diff/6001/net/disk_cache/block_files.h
File net/disk_cache/block_files.h (left):

http://codereview.chromium.org/6599004/diff/6001/net/disk_cache/block_files.h...
net/disk_cache/block_files.h:20: class ThreadChecker;
It kind of sucks we lose the ability to forward declare this, especially in some
of these common files like ipc_channel.h. What if you make ThreadChecker derive
from the Impl one so it can still be forward declared?

[Jói, 2011-03-03 19:06:53]

Please take another look, I've modified the structure to remove header
bloat and the issue with not being able to forward-declare.  Users who
explicitly want the Impl class must now #include a separate file.

I also extended the unit tests to run in release builds (to verify the
do-nothingness of the release-build versions of the classes).

Cheers,
Jói


On Thu, Mar 3, 2011 at 12:39 PM,  <brettw@chromium.org> wrote:
>
> http://codereview.chromium.org/6599004/diff/6001/net/disk_cache/block_files.h
> File net/disk_cache/block_files.h (left):
>
>
http://codereview.chromium.org/6599004/diff/6001/net/disk_cache/block_files.h...
> net/disk_cache/block_files.h:20: class ThreadChecker;
> It kind of sucks we lose the ability to forward declare this, especially
> in some of these common files like ipc_channel.h. What if you make
> ThreadChecker derive from the Impl one so it can still be forward
> declared?
>
> http://codereview.chromium.org/6599004/
>

[brettw, 2011-03-03 22:08:42]

LGTM